Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prevention] Timeout-based Client>Server Validation for Inventory Updates #478

Closed
wants to merge 7 commits into from

Conversation

TradieKM
Copy link

@TradieKM TradieKM commented Dec 17, 2023

Description

Legitimate client inventory data updates will rely on a validation response from the server when attempted.

Players using internet disruption techniques to dupe items in your server will be kicked instead of data being updated and exploited once connections re-established. Additionally, if the action takes longer than 2 seconds to receive a server response for the transaction ID, player is kicked.

Two logging options can be found in the server event 'inventory:statusBreak'

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

Client request server before updating inventory data
Server validation for internet dupers, log is optional and commented - kicks player if they update inventory while not online
@TradieKM TradieKM closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant