Address Code smells

qbicsoftware · Jul 13, 2023 · 9260f56 · 9260f56
1 parent 630650d
commit 9260f56
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...ain/java/life/qbic/datamanager/views/projects/project/samples/SampleDetailsComponent.java b/...ain/java/life/qbic/datamanager/views/projects/project/samples/SampleDetailsComponent.java
@@ -88,7 +88,7 @@ public class SampleDetailsComponent extends PageArea implements Serializable {
   private final BatchRegistrationDialog batchRegistrationDialog = new BatchRegistrationDialog();
   private static final Logger log = getLogger(SampleDetailsComponent.class);
   private final transient SampleDetailsComponentHandler sampleDetailsComponentHandler;
-  private static ProjectId projectId;
+  private ProjectId projectId;
 
   public SampleDetailsComponent(@Autowired SampleInformationService sampleInformationService,
       @Autowired BatchRegistrationService batchRegistrationService,
@@ -153,7 +153,7 @@ private static ComponentRenderer<Div, SamplePreview> createConditionRenderer() {
    * @param projectId ProjectId provided to this component
    */
   public void setProject(ProjectId projectId) {
-    SampleDetailsComponent.projectId = projectId;
+    this.projectId = projectId;
   }
 
   /**

diff --git a/...ain/java/life/qbic/datamanager/views/projects/project/samples/SampleSupportComponent.java b/...ain/java/life/qbic/datamanager/views/projects/project/samples/SampleSupportComponent.java
@@ -25,6 +25,7 @@ public class SampleSupportComponent extends Div {
   private static final Logger log = LoggerFactory.logger(SampleSupportComponent.class);
 
   public SampleSupportComponent() {
+    //Will contain the BatchOverviewComponent
 
   }
 
@@ -37,6 +38,7 @@ public SampleSupportComponent() {
    */
   public void projectId(ProjectId projectId) {
 
+    //Will propagate the ProjectId to the future BatchOverviewComponent
   }
 
 }