Release 0.23.0 #350
Merged
Release 0.23.0 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormationpage (#344) * Rewrite ProjectDetailsComponent to allow for editing via ProjectInformationDialog * Update Javadocs * Address Code Smells * Address Code Smell
* Replace add variable card with add button * Replace add experiment card with add button and title * Minor css changes * Add primary style to add button in ExperimentItemCollection * Clean up css * Refactor DisclaimerCard.java to Disclaimer Div * Remove experimentalFact Sheet * Remove unused imports and ensure that css don't collide
* Draft basic ProjectRoleList * Draft grid which shows Users associated with project * Draft for Acl based permission management * Basic acl service implementation * Comment out ACL based permission handling * Refactor permission evaluator * add todo * Rename AclConfiguration.java to AclSecurityConfiguration.java * Provide basic frontend implementation * Implement User Selection Frontend * Implement ACL * change generation strategy to IDENTItY * Change packages * Add SQL Script for expected role setup * Fix broken test * Add Sid upon user registration * Fix tests * add admin role to every project * fix granting * Push adapted frontend * Push adapted frontend again * remove print command * Allow user to delete or add users to project access and implement hashcode and equals method in user * Show Roles from SID table in ProjectAccessComponent * Show Roles with access to project within ProjectAccessComponent * Grant rights for admin and project manager to projects * Extract first annotation CanCreateProject * Address Code Smells * Remove Todo for now * grant multiple permissions at once Co-authored-by: steffengreiner <[email protected]> * Audit success by default * add user permissions utility * set entry sid to null when deleting sids --------- Co-authored-by: Steffengreiner <[email protected]> Co-authored-by: steffengreiner <[email protected]>
KochTobi
requested changes
Aug 28, 2023
authorization/src/main/java/life/qbic/authorization/acl/ProjectAccessServiceImpl.java
Outdated
Show resolved
Hide resolved
database-connector/src/main/java/life/qbic/authentication/persistence/QBiCSid.java
Outdated
Show resolved
Hide resolved
vaadinfrontend/src/main/java/life/qbic/datamanager/security/AclSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
...rc/main/java/life/qbic/datamanager/views/projects/project/access/ProjectAccessComponent.java
Outdated
Show resolved
Hide resolved
.../java/life/qbic/datamanager/views/projects/project/access/editUserAccessToProjectDialog.java
Outdated
Show resolved
Hide resolved
* Fix invalid class name * Provide JD
|
Kudos, SonarCloud Quality Gate passed!
|
KochTobi
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.