Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #4902, 🐛 Fix the click of week numbers when the first day of the week is not enabled #24

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

balajis-qb
Copy link
Collaborator

Closes Hacker0x01#4902

Problem
As described in the linked issue, the problem occurs when we disable the first week of the day and using excludeDateIntervals whereas the other days of the week are enabled. In this case the select of the week number is not working.

Changes

  • Select the first-enabled day of the week whenever the first day of the week is disabled (Currently it's returning the first day of the week when the first day is not disabled, else it's not selecting anything)
  • Added corresponding test cases to validate the changes

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

@balajis-qb balajis-qb force-pushed the issue-4902/fix/disabled-showWeekNumbers branch from af2e21d to 83543a5 Compare June 17, 2024 09:28
@balajis-qb balajis-qb force-pushed the issue-4902/fix/disabled-showWeekNumbers branch from 83543a5 to f09d92d Compare June 17, 2024 09:40
@balajis-qb balajis-qb merged commit 114f06a into main Jun 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showWeekNumbers with excludeDateIntervals is not working as expected
1 participant