Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5137: Fix the accidental change of the complete month issue with the test cases by selecting to a earlier date in a month #33

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

balajis-qb
Copy link
Collaborator

Closes Hacker0x01#5137

Description

I accidentally found this issue with the existing test cases. The issue we're having is with the test module datepicker_test.test.js. There currently 2 test blocks are having an issue as I mentioned in the attached screenshot

  • DatePicker › should be possible to preSelect minDate (no maxDate set)
  • DatePicker › should be possible to preSelect minDate (maxDate set)

The Problem
image

I shared one of the failed test cases in the above screenshot. The issue there is we're initially getting a selected day using const selectedDayNode = getSelectedDayNode(data.container) and then doing right and left arrow click over it. This test case will work in most of the days except the last day of a month. Because, let's consider 30th Sept, 2024 as the selected date. When the user press right, a new month view will get rendered and then the existing selectedDayNode will not be available to us anymore. But in our code we didn't refetch the selectedDayNode and do Left click on it. So only the left click didn't get fired and the test case failed.

If the selected date is not the end of the month, this test case will work. Because, eventhough the actual selecteDayNode gets changed to the next date on the initial right arrow click, but still the date we stored in selecteDayNode is still accessible to us and left click over it, will inturn handled by the corresponding component and the test case will pass.

The same issue happens in the other mentioned test case

Possible Fixes:
There are 2 ways to fix the issue

  1. Refetch the selectedDayNode after performing the initial right arrow click and perform left click over it
  2. Update the selectedDate and the minDate to some earlier date in a month, so that the right arrow click won't render a new month view

I fixed the issue in the 2nd way as that requires less code change.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

…t cases by selecting to a earlier date in a month

Closes Hacker0x01#5137
@balajis-qb balajis-qb merged commit ce95e64 into main Oct 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with the existing Test cases
1 participant