Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for if a path is given for a remote client URL it is stored as the prefix and not discarded. #876

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix for if a path is given for a remote client URL it is stored as the prefix and not discarded. #876

merged 3 commits into from
Jan 7, 2025

Conversation

rovermicrover
Copy link
Contributor

@rovermicrover rovermicrover commented Jan 3, 2025 •
edited
Loading

Added coverage to both the async and regular client to ensure this bug doesn't come back up again.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests? (https://github.com/rovermicrover/qdrant-client/actions/runs/12604938662/job/35132830550)
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@rovermicrover
Fix for if a path is given for a remote client URL it is stored as th…
df2a9cc 
…e prefix.

Though there is an error thrown if the prefix argument and url path are both present.
@netlify Netlify
Copy link

netlify bot commented Jan 3, 2025 •
edited
Loading

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit e24b59a
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/677c06e2bde4c80008103050
😎 Deploy Preview https://deploy-preview-876--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rovermicrover rovermicrover changed the title Fix for if a path is given for a remote client URL it is stored as the prefix. Fix for if a path is given for a remote client URL it is stored as the prefix and not discarded. Jan 3, 2025
@joein
Copy link
Member

joein commented Jan 6, 2025

Hey @rovermicrover
Thanks for catching this!

@joein
Copy link
Member

joein commented Jan 6, 2025

I refactored it a little bit and removed new async client tests, since async client is auto-generated from the sync one
since this particular functionality is already tested for sync client, there is no need to test it for the async client

@joein joein merged commit 349b35b into qdrant:dev Jan 7, 2025
9 checks passed
joein added a commit that referenced this pull request Jan 16, 2025
@rovermicrover @joein
Fix for if a path is given for a remote client URL it is stored as th…
332253a 
…e prefix and not discarded. (#876)

* Fix for if a path is given for a remote client URL it is stored as the prefix.

Though there is an error thrown if the prefix argument and url path are both present.

* refactoring

* refactoring

---------

Co-authored-by: George Panchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rovermicrover @joein