refactor: add batch_size to qdrant __init__ #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add
batch_sizeparameter to init. The batch_size parameter specified in the init of qdrant for the functionsget_all_documents(), get_all_documents_generator(), get_documents_by_id(),write_documents()(NOT for update_embeddings) not only ensures that there is consistency with other haystack DocumentStores but also allows to specify the batch_size when initializing the DocumentStore which allows for the use of pipelines in a less constrained manner.Related Issue
This PR is related to this issue #37
Changes Made
Added batch size to qdrant init method. The functions
get_all_documents(), get_all_documents_generator(), get_documents_by_id(), write_documents()will take thebatch_sizespecified in the init if not specified.Checklist
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]