Apply tpl() to affinity values to enable reuse of helpers / labels #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^^ @timvisee |
elbart
reviewed
Aug 8, 2024
…labels The Helm tpl function [1] allows to use templates in values. This does make sense where values might want reference existing labels of a Helm chart. This is is the case for Pod affinity (or anti-affinity) which needs to match the labels of the Pods created. This is somewhat inspired by the way this was done for the NGINX Ingress Controller with [2]. [1] https://helm.sh/docs/howto/charts_tips_and_tricks/#using-the-tpl-function [2] kubernetes/ingress-nginx@af9e524 Resolves: qdrant#212 Signed-off-by: Christian Rohmann <[email protected]>
frittentheke
force-pushed
the
affinity_tpl_212
branch
from
c8e82f4 to
77049e6
Compare
|
@frittentheke Thanks a lot for your proactive addition to the qdrant helm chart. We value your participation and are happy you found the chance to support us here. I got feedback from another colleague for this PR! We would kindly ask you to add a test for the affinities. For illustration, this file might serve as an example: https://github.com/qdrant/qdrant-helm/blob/main/test/qdrant_topology-spread-constraints_test.go We then can actually approve/merge this one! Thanks a lot in advance! |
|
Never mind @frittentheke. Thanks a lot for your support. Will provide the unit test myself! PR is here: #217 |
elbart
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Helm tpl function allows to use templates in values. This does make sense where values might want reference existing labels of a Helm chart. This is is the case for Pod affinity (or anti-affinity) which needs to match the labels of the Pods created.
This is somewhat inspired by the way this was done for the NGINX Ingress Controller
Resolves: #212