Apply additional label to headless Service + ServiceMonitor to avoid duplicate scraping #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duplicate scraping Add a common label `app.kubernetes.io/component` ([1]) with value `cluster-discovery` to the headless Service and the ServiceMonitor it's ensured metrics are only scraped once. Using the headless service also makes the most sense, as it has the sole purpose of discovering all Pods making up a qdrant cluster. With `publishNotReadyAddresses: true` metrics are also collected from non-ready pods, see [2]. This is helpful to also collect metrics from Pods that might never become ready to use them for e.g. alerting and problem analysis [1] https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels [2] prometheus-operator/prometheus-operator#5693 Fixes: qdrant#207
|
^^ @timvisee |
|
Thanks for the PR. I just got back from holiday so I was not able to catch this earlier. I'm not familiar with Helm enough to properly review this, so I'll ask some others to take a look. |
bashofmann
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a common label
app.kubernetes.io/component(https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels) with valuecluster-discoveryto the headless Service and the ServiceMonitor it's ensured metrics are only scraped once.Using the headless service also makes the most sense, as it has the sole purpose of discovering all Pods making up a qdrant cluster. With
publishNotReadyAddresses: truemetrics are also collected from non-ready pods, see prometheus-operator/prometheus-operator#5693. This is helpful to also collect metrics from Pods that might never become ready to use them for e.g. alerting and problem analysisFixes: #207