code smells

starsky/starsky.foundation.accountmanagement/Services/UserManager.cs

@@ -211,7 +211,7 @@ private async Task RemoveUserFromCacheAsync(User user)
 			}
 
 			var users = (await AllUsersAsync()).Users;
-			return users.FirstOrDefault(p => p.Id == userTableId);
+			return users.Find(p => p.Id == userTableId);
 		}
 
 		/// <summary>
@@ -284,7 +284,7 @@ public async Task<SignUpResult> SignUpAsync(string name,
 			}
 
 			// Add a user role based on a user id
-			var roleToAdd = roles.FirstOrDefault(p => p.Code == GetRoleAddToUser(identifier,user));
+			var roleToAdd = roles.Find(p => p.Code == GetRoleAddToUser(identifier,user));
 			AddToRole(user, roleToAdd);
 
 			if (credentialType == null)
@@ -555,7 +555,7 @@ public async Task<ValidateResult> ValidateAsync(string credentialTypeCode,
 				return new ValidateResult(success: false, error: ValidateResultError.SecretNotValid);
 			}
 
-			var userData = (await AllUsersAsync()).Users.FirstOrDefault(p => p.Id == credential.UserId);
+			var userData = (await AllUsersAsync()).Users.Find(p => p.Id == credential.UserId);
 			if ( userData == null )
 			{
 				return new ValidateResult(success: false, error: ValidateResultError.UserNotFound);

starsky/starsky.foundation.database/Helpers/FileIndexCompareHelper.cs

@@ -102,13 +102,13 @@ public static List<string> Compare(FileIndexItem sourceIndexItem, FileIndexItem?
             }
 
 	        // Last Edited is not needed
-	        if ( differenceList.Any(p => p == nameof(FileIndexItem.LastEdited).ToLowerInvariant()) )
+	        if ( differenceList.Exists(p => p == nameof(FileIndexItem.LastEdited).ToLowerInvariant()) )
 	        {
 		        differenceList.Remove(nameof(FileIndexItem.LastEdited).ToLowerInvariant());
 	        }
 
 	        // Last Changed is a generated list
-	        if ( differenceList.Any(p => p == nameof(FileIndexItem.LastChanged).ToLowerInvariant()) )
+	        if ( differenceList.Exists(p => p == nameof(FileIndexItem.LastChanged).ToLowerInvariant()) )
 	        {
 		        differenceList.Remove(nameof(FileIndexItem.LastChanged).ToLowerInvariant());
 	        }
@@ -134,7 +134,7 @@ public static FileIndexItem Set(FileIndexItem? sourceIndexItem, string fieldName
 
 		    PropertyInfo[] propertiesA = new FileIndexItem().GetType().GetProperties(
 			    BindingFlags.Public | BindingFlags.Instance);
-		    var property = propertiesA.FirstOrDefault(p =>
+		    var property = Array.Find(propertiesA,p =>
 			    string.Equals(p.Name, fieldName, StringComparison.InvariantCultureIgnoreCase));
 
 		    var fieldType = fieldContent.GetType();
@@ -158,7 +158,7 @@ public static FileIndexItem Set(FileIndexItem? sourceIndexItem, string fieldName
 		    {
 			    PropertyInfo[] propertiesA = new FileIndexItem().GetType()
 				    .GetProperties(BindingFlags.Public | BindingFlags.Instance);
-			    return propertiesA.FirstOrDefault(p => 
+			    return Array.Find(propertiesA,p => 
 				    string.Equals(p.Name, fieldName, StringComparison.InvariantCultureIgnoreCase))?
 				    .GetValue(sourceIndexItem, null);
 		    }

starsky/starsky.foundation.database/Models/ImportIndexItem.cs

@@ -118,7 +118,10 @@ public DateTime ParseDateTimeFromFileName()
         {
             // Depends on 'AppSettingsProvider.Structure'
             // depends on SourceFullFilePath
-            if(string.IsNullOrEmpty(SourceFullFilePath)) {return new DateTime();}
+            if ( string.IsNullOrEmpty(SourceFullFilePath) )
+            {
+	            return new DateTime(0, DateTimeKind.Utc);
+            }
 
             var fileName = Path.GetFileNameWithoutExtension(SourceFullFilePath);
 

starsky/starsky.foundation.database/Query/Query.cs

@@ -477,7 +477,7 @@ public void CacheUpdateItem(List<FileIndexItem> updateStatusContent)
 			    // make it a list to avoid enum errors
 			    displayFileFolders = displayFileFolders.ToList();
 
-			    var obj = displayFileFolders.FirstOrDefault(p => p.FilePath == item.FilePath);
+			    var obj = displayFileFolders.Find(p => p.FilePath == item.FilePath);
 			    if ( obj != null )
 			    {
 				    // remove add again

starsky/starsky.foundation.database/Query/QueryGetObjectsByFileHashAsync.cs

@@ -27,7 +27,7 @@ async Task<List<FileIndexItem>> LocalQuery(ApplicationDbContext context)
 						fileHashesList.Contains(p.FileHash!)).ToListAsync();
 				foreach ( var fileHash in fileHashesList )
 				{
-					if ( result.FirstOrDefault(p => p.FileHash == fileHash) == null )
+					if ( result.Find(p => p.FileHash == fileHash) == null )
 					{
 						result.Add(new FileIndexItem(){FileHash = fileHash, 
 							Status = FileIndexItem.ExifStatus.NotFoundNotInIndex});

starsky/starsky.foundation.database/Query/QuerySingleItem.cs

@@ -88,7 +88,7 @@ public partial class Query
 	            };
             }
 
-            var currentFileIndexItem = fileIndexItemsList.FirstOrDefault(p => p.FileName == fileName);
+            var currentFileIndexItem = fileIndexItemsList.Find(p => p.FileName == fileName);
 
             // Could be not found or not in directory cache
             if ( currentFileIndexItem == null )

starsky/starsky.foundation.database/Thumbnails/ThumbnailQuery.cs

@@ -32,7 +32,7 @@ public ThumbnailQuery(ApplicationDbContext context, IServiceScopeFactory? scopeF
 
 	public Task<List<ThumbnailItem>?> AddThumbnailRangeAsync(List<ThumbnailResultDataTransferModel> thumbnailItems)
 	{
-		if ( thumbnailItems.Any(p => string.IsNullOrEmpty(p.FileHash) ) )
+		if ( thumbnailItems.Exists(p => string.IsNullOrEmpty(p.FileHash) ) )
 		{
 			throw new ArgumentNullException(nameof(thumbnailItems), "[AddThumbnailRangeAsync] FileHash is null or empty");
 		}
@@ -208,8 +208,8 @@ private static async Task<bool> RenameInternalAsync(ApplicationDbContext dbConte
 		var beforeOrNewItems = await dbContext.Thumbnails.Where(p =>
 			p.FileHash == beforeFileHash || p.FileHash == newFileHash).ToListAsync();
 
-		var beforeItem = beforeOrNewItems.FirstOrDefault(p => p.FileHash == beforeFileHash);
-		var newItem = beforeOrNewItems.FirstOrDefault(p => p.FileHash == newFileHash);
+		var beforeItem = beforeOrNewItems.Find(p => p.FileHash == beforeFileHash);
+		var newItem = beforeOrNewItems.Find(p => p.FileHash == newFileHash);
 
 		if ( beforeItem == null) return false;
 

starsky/starsky.foundation.injection/ServiceCollectionExtensions.cs

@@ -138,7 +138,7 @@ private static List<Assembly> GetEntryAssemblyReferencedAssemblies(List<Assembly
 		        // ReSharper disable once ForeachCanBePartlyConvertedToQueryUsingAnotherGetEnumerator
 		        foreach ( var assemblyFilter in assemblyFilters )
 		        {
-			        var isThere = assemblies.Any(p => p.FullName == assemblyName.FullName);
+			        var isThere = assemblies.Exists(p => p.FullName == assemblyName.FullName);
 			        if (IsWildcardMatch(assemblyName.Name!, assemblyFilter) && !isThere )
 			        {
 				        assemblies.Add(AppDomain.CurrentDomain.Load(assemblyName));
@@ -165,7 +165,7 @@ private static Assembly[] GetReferencedAssemblies(List<Assembly> assemblies, IEn
 			        foreach ( var referencedAssembly in assembly.GetReferencedAssemblies() )
 			        {
 				        if ( IsWildcardMatch(referencedAssembly.Name!, assemblyFilter) 
-				             && assemblies.All(p => p.FullName != referencedAssembly.FullName) )
+				             && assemblies.TrueForAll(p => p.FullName != referencedAssembly.FullName) )
 				        {
 					        assemblies.Add(Assembly.Load(referencedAssembly));
 				        }

starsky/starsky.foundation.platform/Helpers/AppSettingsCompareHelper.cs

@@ -1,4 +1,5 @@
 #nullable enable
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
@@ -28,7 +29,7 @@ public static List<string> Compare(AppSettings sourceIndexItem, object? updateOb
             foreach ( var propertyB in propertiesB )
             {
 	            // only for when TransferObject is Nullable<bool> and AppSettings is bool
-	            var propertyInfoFromA = propertiesA.FirstOrDefault(p => p.Name == propertyB.Name);
+	            var propertyInfoFromA = Array.Find(propertiesA, p => p.Name == propertyB.Name);
 	            if ( propertyInfoFromA == null ) continue;
 	            if (propertyInfoFromA.PropertyType == typeof(bool?) && propertyB.PropertyType == typeof(bool?))
 	            {
@@ -277,8 +278,7 @@ internal static void CompareInt(string propertyName, AppSettings sourceIndexItem
 	    /// <returns></returns>
 	    private static object? GetPropertyValue(object car, string propertyName)
 	    {
-		    return car.GetType().GetProperties()
-			    .FirstOrDefault(pi => pi.Name == propertyName)?
+		    return Array.Find(car.GetType().GetProperties(), pi => pi.Name == propertyName)?
 			    .GetValue(car, null);
 	    }
 

starsky/starsky.foundation.platform/Helpers/DateAssembly.cs

@@ -20,7 +20,11 @@ public static DateTime GetBuildDate(Assembly assembly)
 			// <SourceRevisionId>build$([System.DateTime]::UtcNow.ToString("yyyyMMddHHmmss"))</SourceRevisionId>
 			// </PropertyGroup>
 			var attribute = assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>();
-			if ( attribute?.InformationalVersion == null ) return new DateTime();
+			if ( attribute?.InformationalVersion == null )
+			{
+				return new DateTime(0, DateTimeKind.Utc);
+			}
+
 			var value = attribute.InformationalVersion;
 			return ParseBuildTime(value);
 		}
@@ -29,7 +33,10 @@ internal static DateTime ParseBuildTime(string value)
 		{
 			const string buildVersionMetadataPrefix = "+build";
 			var index = value.IndexOf(buildVersionMetadataPrefix, StringComparison.Ordinal);
-			if ( index <= 0 ) return new DateTime();
+			if ( index <= 0 )
+			{
+				return new DateTime(0, DateTimeKind.Utc);
+			}
 			value = value.Substring(index + buildVersionMetadataPrefix.Length);
 			return DateTime.TryParseExact(value, "yyyyMMddHHmmss", CultureInfo.InvariantCulture, 
 				DateTimeStyles.AssumeUniversal, out var result) ? result : new DateTime();

starsky/starsky.foundation.platform/Models/AppSettings.cs

@@ -519,7 +519,7 @@ public bool IsReadOnly(string f)
 		{
 			if (!ReadOnlyFolders.Any() ) return false;
 
-			var result = ReadOnlyFolders.FirstOrDefault(f.Contains);
+			var result = ReadOnlyFolders.Find(f.Contains);
 			return result != null;
 		}
 
@@ -1038,9 +1038,9 @@ public string DatabasePathToFilePath(string databaseFilePath, bool checkIfExist
 		/// </summary>
 		/// <param name="input">the input, the env should start with a $</param>
 		/// <returns>the value or the input when nothing is found</returns>
-		internal string ReplaceEnvironmentVariable(string input)
+		internal static string ReplaceEnvironmentVariable(string input)
 		{
-			if ( string.IsNullOrEmpty(input) || !input.StartsWith("$") ) return input;
+			if ( string.IsNullOrEmpty(input) || !input.StartsWith('$') ) return input;
 			var value = Environment.GetEnvironmentVariable(input.Remove(0, 1));
 			return string.IsNullOrEmpty(value) ? input : value;
 		}

starsky/starsky.foundation.readmeta/Helpers/GeoParser.cs

@@ -88,7 +88,7 @@ public static GeoListItem ParseIsoString(string isoStr)
 
             // Check for minimum length
             // Check for trailing slash
-            if ( isoStr.Length < 18 || !isoStr.EndsWith("/") )
+            if ( isoStr.Length < 18 || !isoStr.EndsWith('/') )
             {
 	            return geoListItem;
             }

starsky/starskytest/FakeMocks/FakeIQuery.cs

@@ -258,7 +258,7 @@ public Task<List<FileIndexItem>> GetObjectsByFileHashAsync(List<string> fileHash
 
 			foreach ( var fileHash in fileHashesList )
 			{
-				if ( result.FirstOrDefault(p => p.FileHash == fileHash) == null )
+				if ( result.Find(p => p.FileHash == fileHash) == null )
 				{
 					result.Add(new FileIndexItem(){FileHash = fileHash, 
 						Status = FileIndexItem.ExifStatus.NotFoundNotInIndex});

starsky/starskytest/starsky.foundation.platform/Models/AppSettingsTest.cs

@@ -63,21 +63,21 @@ public void AppSettingsProviderTest_SqLiteFullPathTest()
 		[TestMethod]
 		public void ReplaceEnvironmentVariable_Nothing()
 		{
-			var value = _appSettings.ReplaceEnvironmentVariable(string.Empty);
+			var value = AppSettings.ReplaceEnvironmentVariable(string.Empty);
 			Assert.AreEqual(string.Empty, value);
 		}
 
 		[TestMethod]
 		public void ReplaceEnvironmentVariable_SomethingThatShouldBeIgnored()
 		{
-			var value = _appSettings.ReplaceEnvironmentVariable("/test");
+			var value = AppSettings.ReplaceEnvironmentVariable("/test");
 			Assert.AreEqual("/test", value);
 		}
 
 		[TestMethod]
 		public void ReplaceEnvironmentVariable_Non_Existing_EnvVariable()
 		{
-			var value = _appSettings.ReplaceEnvironmentVariable("$sdhfdskfbndsfjb38");
+			var value = AppSettings.ReplaceEnvironmentVariable("$sdhfdskfbndsfjb38");
 			Assert.AreEqual("$sdhfdskfbndsfjb38", value);
 		}
 
@@ -86,7 +86,7 @@ public void ReplaceEnvironmentVariable_Existing_EnvVariable()
 		{
 			Environment.SetEnvironmentVariable("test123456789","123456789");
 			// should start with a dollar sign
-			var value = _appSettings.ReplaceEnvironmentVariable("$test123456789");
+			var value = AppSettings.ReplaceEnvironmentVariable("$test123456789");
 			Assert.AreEqual("123456789", value);
 		}