Skip to content

Commit

Permalink
Merge pull request #1733 from qdraw/feature/202409_tweaks
Browse files Browse the repository at this point in the history 
small tweaks
  • Loading branch information
@qdraw
qdraw authored Sep 27, 2024
2 parents eb9d95d + 8b2daf2 commit 8d0a8f3
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 42 deletions.
8 changes: 4 additions & 4 deletions starsky/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopApp.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace starsky.foundation.native.OpenApplicationNative.Helpers;
public static class WindowsOpenDesktopApp
{
/// <summary>
/// Add check if is Windows
/// Add check if is Windows
/// </summary>
/// <param name="fileUrls">full file paths</param>
/// <param name="platform">running platform</param>
Expand Down Expand Up @@ -35,7 +35,7 @@ public static class WindowsOpenDesktopApp
}

/// <summary>
/// Does NOT check if file exists
/// Does NOT check if file exists
/// </summary>
/// <param name="fileUrl">Absolute Path of file</param>
/// <returns></returns>
Expand All @@ -60,7 +60,7 @@ public static class WindowsOpenDesktopApp
}

/// <summary>
/// Skip if is MacOS
/// Skip if is Mac OS
/// </summary>
/// <param name="fileUrls"></param>
/// <param name="applicationUrl"></param>
Expand All @@ -76,7 +76,7 @@ public static class WindowsOpenDesktopApp
}

/// <summary>
/// Internal
/// Internal
/// </summary>
/// <param name="fileUrls"></param>
/// <param name="applicationUrl"></param>
Expand Down
62 changes: 30 additions & 32 deletions starsky/starskytest/FakeCreateAn/CreateAnXmp.cs
View file
Original file line number Diff line number Diff line change
@@ -1,37 +1,35 @@
using System.Collections.Immutable;
using System.Diagnostics.CodeAnalysis;
using System.Text;

namespace starskytest.FakeCreateAn
namespace starskytest.FakeCreateAn;

public static class CreateAnXmp
{
public static class CreateAnXmp
{
[SuppressMessage("ReSharper", "StringLiteralTypo")]
private static readonly string XmpString =
"<x:xmpmeta xmlns:x=\"adobe:ns:meta/\" x:xmptk=\"Image::ExifTool 11.16\"><rdf:RDF xmlns:" +
"rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\"><rdf:Description xmlns:exif=\"http:" +
"//ns.adobe.com/exif/1.0/\" rdf:about=\"\"><exif:DateTimeOriginal>2020-03-14T14:00:51</e" +
"xif:DateTimeOriginal><exif:ExposureTime>1/1600</exif:ExposureTime><exif:FNumber>11/5</e" +
"xif:FNumber><exif:FocalLength>4404019/1048576</exif:FocalLength><exif:GPSAltitude>1/1</e" +
"xif:GPSAltitude><exif:GPSAltitudeRef>0</exif:GPSAltitudeRef><exif:GPSLatitude>52,15.73N<" +
"/exif:GPSLatitude><exif:GPSLongitude>6,2.37E</exif:GPSLongitude><exif:ISOSpeedRatings><r" +
"df:Seq><rdf:li>25</rdf:li><rdf:li>25</rdf:li></rdf:Seq></exif:ISOSpeedRatings></rdf:Desc" +
"ription><rdf:Description xmlns:photomechanic=\"http://ns.camerabits.com/photomechanic/1." +
"0/\" rdf:about=\"\"><photomechanic:ColorClass>7</photomechanic:ColorClass><photomechanic" +
":Prefs>0:7:0:0</photomechanic:Prefs></rdf:Description><rdf:Description xmlns:photoshop=\"" +
"http://ns.adobe.com/photoshop/1.0/\" rdf:about=\"\"><photoshop:DateCreated>2020-03-14T14" +
":00:51</photoshop:DateCreated></rdf:Description><rdf:Description xmlns:tiff=\"http://ns." +
"adobe.com/tiff/1.0/\" rdf:about=\"\"><tiff:Make>Apple</tiff:Make><tiff:Model>iPhone SE<" +
"/tiff:Model><tiff:Orientation>3</tiff:Orientation><tiff:Software>Qdraw 1.0</tiff:Softwa" +
"re></rdf:Description><rdf:Description xmlns:xmp=\"http://ns.adobe.com/xap/1.0/\" rdf:ab" +
"out=\"\"><xmp:CreateDate>2020-03-14T14:00:51</xmp:CreateDate><xmp:CreatorTool>Qdraw 1.0" +
"</xmp:CreatorTool><xmp:Label>Extras</xmp:Label><xmp:ModifyDate>2020-03-14T14:00:51</xmp" +
":ModifyDate></rdf:Description><rdf:Description xmlns:stEvt=\"http://ns.adobe.com/xap/1." +
"0/sType/ResourceEvent#\" xmlns:xmpMM=\"http://ns.adobe.com/xap/1.0/mm/\" rdf:about=\"\"" +
"><xmpMM:History><rdf:Seq><rdf:li rdf:parseType=\"Resource\"><stEvt:softwareAgent>Qdraw " +
"1.0</stEvt:softwareAgent></rdf:li></rdf:Seq></xmpMM:History></rdf:Description></rdf:RDF>" +
"</x:xmpmeta>";

public static readonly ImmutableArray<byte> Bytes = Encoding.ASCII.GetBytes(XmpString).ToImmutableArray();
}
private const string XmpString =
"<x:xmpmeta xmlns:x=\"adobe:ns:meta/\" x:xmptk=\"Image::ExifTool 11.16\"><rdf:RDF xmlns:" +
"rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\"><rdf:Description xmlns:exif=\"http:" +
"//ns.adobe.com/exif/1.0/\" rdf:about=\"\"><exif:DateTimeOriginal>2020-03-14T14:00:51</e" +
"xif:DateTimeOriginal><exif:ExposureTime>1/1600</exif:ExposureTime><exif:FNumber>11/5</e" +
"xif:FNumber><exif:FocalLength>4404019/1048576</exif:FocalLength><exif:GPSAltitude>1/1</e" +
"xif:GPSAltitude><exif:GPSAltitudeRef>0</exif:GPSAltitudeRef><exif:GPSLatitude>52,15.73N<" +
"/exif:GPSLatitude><exif:GPSLongitude>6,2.37E</exif:GPSLongitude><exif:ISOSpeedRatings><r" +
"df:Seq><rdf:li>25</rdf:li><rdf:li>25</rdf:li></rdf:Seq></exif:ISOSpeedRatings></rdf:Desc" +
"ription><rdf:Description xmlns:photomechanic=\"http://ns.camerabits.com/photomechanic/1." +
"0/\" rdf:about=\"\"><photomechanic:ColorClass>7</photomechanic:ColorClass><photomechanic" +
":Prefs>0:7:0:0</photomechanic:Prefs></rdf:Description><rdf:Description xmlns:photoshop=\"" +
"http://ns.adobe.com/photoshop/1.0/\" rdf:about=\"\"><photoshop:DateCreated>2020-03-14T14" +
":00:51</photoshop:DateCreated></rdf:Description><rdf:Description xmlns:tiff=\"http://ns." +
"adobe.com/tiff/1.0/\" rdf:about=\"\"><tiff:Make>Apple</tiff:Make><tiff:Model>iPhone SE<" +
"/tiff:Model><tiff:Orientation>3</tiff:Orientation><tiff:Software>Qdraw 1.0</tiff:Softwa" +
"re></rdf:Description><rdf:Description xmlns:xmp=\"http://ns.adobe.com/xap/1.0/\" rdf:ab" +
"out=\"\"><xmp:CreateDate>2020-03-14T14:00:51</xmp:CreateDate><xmp:CreatorTool>Qdraw 1.0" +
"</xmp:CreatorTool><xmp:Label>Extras</xmp:Label><xmp:ModifyDate>2020-03-14T14:00:51</xmp" +
":ModifyDate></rdf:Description><rdf:Description xmlns:stEvt=\"http://ns.adobe.com/xap/1." +
"0/sType/ResourceEvent#\" xmlns:xmpMM=\"http://ns.adobe.com/xap/1.0/mm/\" rdf:about=\"\"" +
"><xmpMM:History><rdf:Seq><rdf:li rdf:parseType=\"Resource\"><stEvt:softwareAgent>Qdraw " +
"1.0</stEvt:softwareAgent></rdf:li></rdf:Seq></xmpMM:History></rdf:Description></rdf:RDF>" +
"</x:xmpmeta>";

public static readonly ImmutableArray<byte> Bytes =
[..Encoding.ASCII.GetBytes(XmpString)];
}
11 changes: 5 additions & 6 deletions ...est/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopAppTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,39 +82,38 @@ private static CreateFakeStarskyWindowsExe SetupEnsureAssociationsSet()
[TestMethod]
public void W_OpenDefault_NonWindows()
{
// this does nothing
var result =
WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault_NonWindows any value"],
OSPlatform.Linux);
Assert.IsNull(result);
}

[TestMethod]
public void W_OpenDefault2_NonWindows()
public void W_OpenDefault2_NonWindows_WithFlag()
{
if ( new AppSettings().IsWindows )
{
Assert.Inconclusive("This test if for Unix Only");
return;
}

var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault2_NonWindows any value"],
var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault2_NonWindows_WithFlag.txt"],
OSPlatform.Windows);

Assert.IsTrue(result);
}

[TestMethod]
public void W_OpenDefault3_NonWindows()
public void W_OpenDefault3_NonWindows_NoFlag()
{
if ( new AppSettings().IsWindows )
{
Assert.Inconclusive("This test if for Unix Only");
return;
}

var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault3_NonWindows any value"]);

Console.WriteLine(result);
var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault3_NonWindows_NoFlag"]);

Assert.IsTrue(result);
}
Expand Down

0 comments on commit 8d0a8f3

Please sign in to comment.