Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipboard async bug and code smells #1200

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Jul 30, 2023

PR Details

Description / Motivation and Context

Clipboard helper async

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #1200 (6cc4ae3) into master (10457bc) will increase coverage by 0.03%.
The diff coverage is 87.50%.

❗ Current head 6cc4ae3 differs from pull request most recent head 8489ae5. Consider uploading reports for the commit 8489ae5 to get more accurate results

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
+ Coverage   93.93%   93.96%   +0.03%     
==========================================
  Files         547      547              
  Lines       18881    18893      +12     
  Branches     3125     3126       +1     
==========================================
+ Hits        17736    17753      +17     
+ Misses        622      619       -3     
+ Partials      523      521       -2     
Flag Coverage Δ
all 93.96% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ture.webhtmlpublish/Helpers/ToBase64DataUriList.cs 100.00% <ø> (ø)
...n.storage/Storage/StorageHostFullPathFilesystem.cs 82.01% <ø> (ø)
...src/components/atoms/notification/notification.tsx 87.50% <ø> (ø)
.../molecules/search-pagination/search-pagination.tsx 88.23% <ø> (ø)
...arsky/starsky/clientapp/src/interfaces/IArchive.ts 100.00% <ø> (ø)
...ky/starsky/clientapp/src/interfaces/IDetailView.ts 100.00% <ø> (ø)
...starsky/clientapp/src/interfaces/IFileIndexItem.ts 100.00% <ø> (ø)
...arsky/starsky/Controllers/MetaReplaceController.cs 96.96% <50.00%> (-3.04%) ⬇️
...oundation.readmeta/ReadMetaHelpers/ReadMetaExif.cs 91.32% <76.47%> (+1.76%) ⬆️
...bnail/Services/ManualThumbnailGenerationService.cs 100.00% <100.00%> (ø)
... and 12 more

... and 1 file with indirect coverage changes

@qdraw qdraw changed the title bug clipboard async bug Jul 31, 2023
@qdraw qdraw changed the title clipboard async bug clipboard async bug and code smells Jul 31, 2023
@qdraw qdraw merged commit 541c5c5 into master Jul 31, 2023
16 checks passed
@qdraw qdraw deleted the feature/202307_code_smells_30 branch July 31, 2023 14:46
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.0% 93.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant