Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code smells #1202

Merged
merged 10 commits into from
Aug 1, 2023
Merged

code smells #1202

merged 10 commits into from
Aug 1, 2023

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Aug 1, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1202 (899ff06) into master (d4937c9) will increase coverage by 0.05%.
Report is 3 commits behind head on master.
The diff coverage is 89.10%.

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
+ Coverage   93.98%   94.03%   +0.05%     
==========================================
  Files         547      547              
  Lines       18895    18888       -7     
  Branches     3126     3125       -1     
==========================================
+ Hits        17758    17761       +3     
+ Misses        619      613       -6     
+ Partials      518      514       -4     
Flag Coverage Δ
all 94.03% <89.10%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
starsky/starsky.feature.import/Services/Import.cs 96.71% <ø> (ø)
starsky/starsky/Program.cs 89.18% <ø> (ø)
...ze-manually/modal-archive-synchronize-manually.tsx 60.71% <0.00%> (ø)
...ndation.database/Helpers/FileIndexCompareHelper.cs 89.84% <89.84%> (-0.09%) ⬇️
...arsky.feature.search/ViewModels/SearchViewModel.cs 91.44% <100.00%> (ø)
...starsky.foundation.sync/SyncServices/SyncFolder.cs 99.51% <100.00%> (ø)
...rsky.foundation.sync/SyncServices/SyncMultiFile.cs 98.98% <100.00%> (ø)
...sky.foundation.sync/SyncServices/SyncSingleFile.cs 94.23% <100.00%> (ø)
...app/src/components/atoms/list-image/list-image.tsx 90.32% <100.00%> (+16.24%) ⬆️
.../force-sync-wait-button/force-sync-wait-button.tsx 94.11% <100.00%> (ø)
... and 5 more

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@qdraw qdraw merged commit d0dfefd into master Aug 1, 2023
16 checks passed
@qdraw qdraw deleted the feature/202308_code_smells_01 branch August 1, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant