code smells

[qdraw]

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

• C# Unit tests
• Typescript Unit tests
• Other Unit tests
• Manual tests
• Automatic End2end tests (starsky-tools/end2end)

Types of changes

• Added for new features
• Breaking change fix or feature that would cause existing functionality to change
• Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
• Deprecated for soon-to-be removed features
• Removed for now removed features
• Fixed for any bug fixes
• Security in case of vulnerabilities

Checklist

• My code follows the code style of this project.
• I have updated the documentation accordingly (update when needed)
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the ./history.md document

[codecov]

Codecov Report

Merging #1203 (b40d0d4) into master (899ff06) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
- Coverage   94.03%   94.01%   -0.03%     
==========================================
  Files         547      548       +1     
  Lines       18888    18916      +28     
  Branches     3125     3135      +10     
==========================================
+ Hits        17761    17783      +22     
- Misses        613      616       +3     
- Partials      514      517       +3     

Flag	Coverage Δ
all	94.01% <76.47%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ndation.database/Helpers/FileIndexCompareHelper.cs	89.84% <ø> (ø)
...ailview-info-datetime/detailview-info-datetime.tsx	91.66% <0.00%> (ø)
...components/organisms/menu-archive/menu-archive.tsx	72.05% <ø> (ø)
...c/components/organisms/menu-search/menu-search.tsx	70.73% <ø> (ø)
...ts/organisms/detail-view-media/detail-view-mp4.tsx	69.66% <60.00%> (-0.58%)	⬇️
...ts/organisms/menu-detail-view/menu-detail-view.tsx	74.45% <62.50%> (-0.17%)	⬇️
...p/src/components/organisms/modal-geo/modal-geo.tsx	87.17% <66.66%> (-1.87%)	⬇️
.../src/components/atoms/form-control/limit-length.ts	69.23% <100.00%> (+1.23%)	⬆️
...archive-sidebar/archive-sidebar-selection-list.tsx	90.00% <100.00%> (ø)
...ecules/item-text-list-view/item-text-list-view.tsx	93.33% <100.00%> (+3.33%)	⬆️
... and 3 more

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

85.5% Coverage
2.2% Duplication