Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code style && change to button and menuOption/menuOptionModal #1310

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Dec 13, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cecddc1) 94.73% compared to head (05f9360) 94.77%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
+ Coverage   94.73%   94.77%   +0.04%     
==========================================
  Files         576      576              
  Lines       20306    20298       -8     
  Branches     3165     3164       -1     
==========================================
+ Hits        19236    19238       +2     
+ Misses        702      693       -9     
+ Partials      368      367       -1     
Flag Coverage Δ
all 94.77% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw changed the title add fix for code smells code style && change to button and menuOption/menuOptionModal Dec 14, 2023
Copy link

sonarcloud bot commented Dec 14, 2023

@qdraw qdraw merged commit 2c9a77a into master Dec 14, 2023
14 checks passed
@qdraw qdraw deleted the feature/202312_code_smells_14 branch December 14, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant