Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger autogen is broken after .NET 8 upgrade #1348

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Jan 25, 2024

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (805e50e) 94.65% compared to head (e6d8bbd) 94.68%.
Report is 2 commits behind head on master.

Files Patch % Lines
starsky/starsky/Startup.cs 89.47% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
+ Coverage   94.65%   94.68%   +0.03%     
==========================================
  Files         582      582              
  Lines       21091    21106      +15     
  Branches     3229     3235       +6     
==========================================
+ Hits        19963    19984      +21     
+ Misses        728      721       -7     
- Partials      400      401       +1     
Flag Coverage Δ
all 94.68% <90.90%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw changed the title Swagger autogen is broken Swagger autogen is broken after .NET 8 upgrade Jan 25, 2024
Copy link

sonarcloud bot commented Jan 25, 2024

@qdraw qdraw merged commit a56b952 into master Jan 25, 2024
24 checks passed
@qdraw qdraw deleted the feature/202401_swagger_gen branch January 25, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant