Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorclass filter refactor, rename shared > internal, change formating and jest depr. values #1364

Merged
merged 8 commits into from
Feb 4, 2024

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Feb 4, 2024

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (5d702e6) 95.23% compared to head (7ad9a6a) 95.40%.

Files Patch % Lines
...ze-manually/modal-archive-synchronize-manually.tsx 53.84% 6 Missing ⚠️
...anisms/detail-view-sidebar/detail-view-sidebar.tsx 62.50% 3 Missing ⚠️
...nents/atoms/file-hash-image/pan-and-zoom-image.tsx 71.42% 2 Missing ⚠️
...olecules/archive-pagination/archive-pagination.tsx 88.23% 2 Missing ⚠️
...olecules/menu-inline-search/menu-inline-search.tsx 83.33% 2 Missing ⚠️
.../molecules/search-pagination/search-pagination.tsx 94.11% 2 Missing ⚠️
...components/organisms/menu-archive/menu-archive.tsx 81.81% 2 Missing ⚠️
...c/components/organisms/menu-search/menu-search.tsx 75.00% 2 Missing ⚠️
...archive-sidebar/archive-sidebar-selection-list.tsx 80.00% 1 Missing ⚠️
...olecules/color-class-filter/color-class-filter.tsx 97.87% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
+ Coverage   95.23%   95.40%   +0.16%     
==========================================
  Files         593      596       +3     
  Lines       22359    22131     -228     
  Branches     4245     4123     -122     
==========================================
- Hits        21294    21114     -180     
+ Misses        672      633      -39     
+ Partials      393      384       -9     
Flag Coverage Δ
all 95.40% <95.70%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw changed the title Colorclass filter refactor Colorclass filter refactor, rename shared > internal, change formating and jest depr. values Feb 4, 2024
Copy link

sonarcloud bot commented Feb 4, 2024

@qdraw qdraw merged commit e19559d into master Feb 4, 2024
13 checks passed
@qdraw qdraw deleted the feature/202402_colorclass_filter_refactor branch February 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant