Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of hard dependency of Application Insights > Open Telemetry #1366

Merged
merged 43 commits into from
Feb 9, 2024

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Feb 5, 2024

PR Details

Description / Motivation and Context

class ExportService / download
Import
Update api
RENAME
WebHTML publish

  • DataProtectionKey Max
  • Electron CSP
  • Tracking bg jobs

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@qdraw qdraw added this to the Release 0.6.0 milestone Feb 5, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (c35b523) 95.39% compared to head (2cb0d49) 95.34%.

Files Patch % Lines
...e.webhtmlpublish/Services/WebHtmlPublishService.cs 86.45% 19 Missing and 7 partials ⚠️
...undation.accountmanagement/Services/UserManager.cs 84.52% 5 Missing and 8 partials ⚠️
....feature.metaupdate/Services/MetaReplaceService.cs 80.43% 7 Missing and 2 partials ⚠️
...arsky.feature.search/ViewModels/SearchViewModel.cs 88.57% 0 Missing and 8 partials ⚠️
...y/starsky.feature.search/Services/SearchService.cs 96.84% 2 Missing and 4 partials ⚠️
...eature.search/Services/SearchSuggestionsService.cs 68.42% 2 Missing and 4 partials ⚠️
...y/starsky.feature.export/Services/ExportService.cs 96.22% 0 Missing and 4 partials ⚠️
starsky/starsky.feature.import/Services/Import.cs 97.43% 1 Missing and 3 partials ⚠️
....foundation.database/Helpers/MySqlDatabaseFixes.cs 86.66% 0 Missing and 4 partials ⚠️
...y.foundation.database/Helpers/StatusCodesHelper.cs 91.83% 1 Missing and 3 partials ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   95.39%   95.34%   -0.06%     
==========================================
  Files         596      585      -11     
  Lines       22107    22114       +7     
  Branches     4120     4074      -46     
==========================================
- Hits        21090    21084       -6     
- Misses        633      648      +15     
+ Partials      384      382       -2     
Flag Coverage Δ
all 95.34% <94.72%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 9, 2024

@qdraw qdraw merged commit fe8377b into master Feb 9, 2024
13 of 16 checks passed
@qdraw qdraw deleted the feature/202402_rm_app_insights_direct branch February 9, 2024 18:56
@qdraw qdraw linked an issue Feb 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish issue
1 participant