Fix Sonarcloud issues / Suppress non issues

pipelines/azure/develop-ci.yml

@@ -58,7 +58,7 @@ stages:
   jobs:
   - job: buildnetcore
     displayName: 'Build'
-    timeoutInMinutes: 25 # how long to run the job before automatically cancelling
+    timeoutInMinutes: 30 # how long to run the job before automatically cancelling
     cancelTimeoutInMinutes: 10 # how much time to give 'run always even if cancelled tasks' before stopping them
     pool:
       vmImage: 'ubuntu-22.04'

starsky/build/Build.cs

@@ -22,6 +22,9 @@ namespace build;
 [SuppressMessage("Sonar",
 	"S2629: Don't use string interpolation in logging message templates",
 	Justification = "Not production code.")]
+[SuppressMessage("Sonar",
+	"S6664: Reduce the number of Information logging calls within this code block",
+	Justification = "Not production code.")]
 [ShutdownDotNetAfterServerBuild]
 public sealed class Build : NukeBuild
 {

starsky/build/helpers/DotnetGenericHelper.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using build;
 using Nuke.Common.ProjectModel;
@@ -9,6 +10,9 @@
 
 namespace helpers
 {
+	[SuppressMessage("Sonar",
+		"S6664: Reduce the number of Information logging calls within this code block",
+		Justification = "Not production code.")]
 	public static class DotnetGenericHelper
 	{
 		/// <summary>

starsky/build/helpers/DotnetTestHelper.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using build;
 using Nuke.Common.IO;
@@ -9,6 +10,9 @@
 
 namespace helpers
 {
+	[SuppressMessage("Sonar",
+		"S6664: Reduce the number of Information logging calls within this code block",
+		Justification = "Not production code.")]
 	public static class DotnetTestHelper
 	{
 		static bool DirectoryExists(string path)

starsky/build/helpers/SonarQube.cs

@@ -18,6 +18,9 @@ namespace helpers
 	[SuppressMessage("Sonar",
 		"S2629: Don't use string interpolation in logging message templates",
 		Justification = "Not production code.")]
+	[SuppressMessage("Sonar",
+		"S6664: Reduce the number of Information logging calls within this code block",
+		Justification = "Not production code.")]
 	public static class SonarQube
 	{
 		public const string SonarQubePackageName = "dotnet-sonarscanner";

starsky/build/helpers/TrxParserHelper.cs

@@ -8,6 +8,9 @@
 
 namespace helpers;
 
+[SuppressMessage("Sonar",
+	"S6664: Reduce the number of Information logging calls within this code block",
+	Justification = "Not production code.")]
 public static class TrxParserHelper
 {
 	/// <summary>

starsky/starsky.foundation.database/Data/GlobalSuppressions.cs

@@ -1,5 +1,7 @@
 using System.Diagnostics.CodeAnalysis;
 
+// GlobalSuppressions.cs
+
 // S1309: Do not suppress issues.
 [assembly:
 	SuppressMessage("Sonar", "S1309",

starsky/starsky/GlobalSuppressions.cs

@@ -0,0 +1,12 @@
+using System.Diagnostics.CodeAnalysis;
+
+// GlobalSuppressions.cs
+
+// S6931:Change the paths of the actions of this controller to be relative
+// and add a controller route with the common prefix.
+[assembly:
+	SuppressMessage("Sonar", "S6931",
+		Justification =
+			"Change the paths of the actions of this controller to be relative and " +
+			"add a controller route with the common prefix.",
+		Scope = "module")]

starsky/starsky/clientapp/src/shared/update-relative-object.ts

@@ -34,7 +34,7 @@ export class UpdateRelativeObject {
           setRelativeObjects(result.data);
           resolve(result.data);
         })
-        .catch((err) => {
+        .catch((err: Error) => {
           console.error(err);
           rejects(err);
         });