Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTC client WIP #954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UTC client WIP #954

wants to merge 1 commit into from

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Nov 6, 2022

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #954 (c672d60) into master (9e459e1) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
+ Coverage   91.57%   91.75%   +0.18%     
==========================================
  Files         481      481              
  Lines       16832    16837       +5     
  Branches     2820     2820              
==========================================
+ Hits        15414    15449      +35     
+ Misses        856      825      -31     
- Partials      562      563       +1     
Flag Coverage Δ
all 91.75% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
starsky/starsky/clientapp/src/shared/date.ts 98.64% <100.00%> (+0.09%) ⬆️
....foundation.writemeta/Services/ExifToolDownload.cs 92.02% <0.00%> (+2.89%) ⬆️
...rsky.foundation.worker/Helpers/ProcessTaskQueue.cs 100.00% <0.00%> (+4.00%) ⬆️
...arsky/starsky.feature.geolookup/Services/GeoCli.cs 91.42% <0.00%> (+4.28%) ⬆️
starsky/starskygeocli/Program.cs 100.00% <0.00%> (+9.52%) ⬆️
...rsky.feature.geolookup/Services/GeoFileDownload.cs 60.52% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@qdraw qdraw changed the title WIP UTC client WIP Dec 6, 2022
@qdraw qdraw added this to the Release 0.6.x (after 0) milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant