Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX BlockMeta repeat #20 ? #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

atravert
Copy link
Contributor

@atravert atravert commented Jun 8, 2022

In some instances, multiple entries with same name - in particular 'AB' seem to be present. In case of 'AB' only the the first one is valid. The supplementary instances are kept and added in the dict with a key ending by '(1)', '(2)', etc...

This should fix issues #20 and #15

In some instances, multiple entries - in particular 'AB' seem to be present, onlky the the first one is valid.
The supplementary instances are kept and added in the dict with a key ending by '_(1)', '_(2)', etc...
@atravert atravert changed the title FIX parse_data with sama names FIX parse_data with same names Jun 8, 2022
@atravert atravert changed the title FIX parse_data with same names FIX parse_data with same names, see BlockMeta repeat #20 Jun 8, 2022
@atravert atravert changed the title FIX parse_data with same names, see BlockMeta repeat #20 FIX BlockMeta repeat #20 ? Jun 8, 2022
This was referenced Jun 8, 2022
FIX multiple entries with same name: In some instances, multiple entries - in particular 'AB' seem to be present, only the the first one is valid.
Now the  supplementary entries are kept and added in the dict with a key ending by '(1)', '(2)', etc...
@philipp-baumann
Copy link

philipp-baumann commented Sep 1, 2022

Can confirm this. So far I have only found files with two spectral AB or Refl blocks, because of atmospheric compensation. That is how we deal in the R implementation. To join knowledge, would be great to know if this "additional_type" can be only 0 or 64, or actually have more representations (what you have solved with the dict stated above). https://github.com/spectral-cockpit/opusreader2/blob/e503ce3ae51155a77a1f94bae8eff9af1092fae4/R/read_header.R#L33

Copy link
Contributor

@dzjkb dzjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipe/meta.yaml.bak added accidentally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants