Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Quantized Mesh support #9294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document Quantized Mesh support #9294

wants to merge 1 commit into from

Conversation

dvdkon
Copy link

@dvdkon dvdkon commented Oct 6, 2024

This PR documents the new Quantized Mesh support in QGIS: Adding layers, displaying them in the 2D map view and using them as 3D terrain.

Ticket(s): fix #9275

  • Backport to LTR documentation is requested

@DelazJ
Copy link
Collaborator

DelazJ commented Oct 7, 2024

@dvdkon thanks a lot for your contribution.
Unless I misread, adding a quantized mesh is kind of adding a specific scene, and we are here almost duplicating the instructions while this imo could be merged with the cesium. What do you think?

@dvdkon
Copy link
Author

dvdkon commented Oct 8, 2024

@dvdkon thanks a lot for your contribution. Unless I misread, adding a quantized mesh is kind of adding a specific scene, and we are here almost duplicating the instructions while this imo could be merged with the cesium. What do you think?

Thanks for the feedback. I initially wrote the instructions separately, because I feel that for users, Cesium 3D tiles and Quantized Mesh tiles don't have that much in common; their grouping under "scenes" is mostly an artefact of QGIS internals, them both being 3D online tiled datasets.

But it's true that the adding process is 90% the same, so I tried to unify the instructions. Does this seem like an improvement to you, or should I keep the separate instructions? I can see the case for either.

@selmaVH1
Copy link
Collaborator

selmaVH1 commented Oct 9, 2024

Thanks for the feedback. I initially wrote the instructions separately, because I feel that for users, Cesium 3D tiles and Quantized Mesh tiles don't have that much in common; their grouping under "scenes" is mostly an artefact of QGIS internals, them both being 3D online tiled datasets.

I also think the process of adding Quantized Mesh tiles should be merged with Cesium 3D tiles, as both are added through the Scene. The 'Opening Data' section is primarily for explaining how to add data into QGIS. However, if there are any key differences between the two, since both are 3D online tiles, I suggest we describe those differences in this chapter.

@DelazJ
Copy link
Collaborator

DelazJ commented Oct 10, 2024

But it's true that the adding process is 90% the same, so I tried to unify the instructions. Does this seem like an improvement to you, or should I keep the separate instructions? I can see the case for either.

The merged one looks better to me. Thanks @dvdkon .

@DelazJ
Copy link
Collaborator

DelazJ commented Oct 10, 2024

since both are 3D online tiles, I suggest we describe those differences in this chapter.

And yes it could be worth expanding on quantized mesh in tiles chapter...

@dvdkon
Copy link
Author

dvdkon commented Oct 11, 2024

Thanks for your feedback. I've pushed the combined instructions and tried to outline the main differences in purpose between our supported 3D tile formats in "Working with 3D Tiles".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GUI for adding Quantized Mesh layers (Request in QGIS)
3 participants