Merge pull request #66 from Xpirix/plugin_href_link

Make the plugins names as links
qgis · Feb 12, 2025 · 863a6b6 · 863a6b6
2 parents 2cfcf1c + eec1e5d
commit 863a6b6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/qgis-app/plugins/templates/plugins/plugin_list.html b/qgis-app/plugins/templates/plugins/plugin_list.html
@@ -115,7 +115,7 @@ <h2 class="title is-4">{% if title %}{{title}}{% else %}{% trans "All plugins" %
 			</thead>
 			<tbody>
 				{% for object in object_list %}
-				<tr class="pmain {% if object.deprecated %} has-background-danger-light{% endif %}" id="pmain{{object.pk}}" onclick="window.location.href='{% url "plugin_detail" object.package_name %}';">
+				<tr class="pmain {% if object.deprecated %} has-background-danger-light{% endif %} clickable-row" id="pmain{{object.pk}}">
 					<td style="min-width: 46px;">
 					{% if object.icon and object.icon.file and object.icon|is_image_valid %}
 						{% with image_extension=object.icon.name|file_extension %}
@@ -131,9 +131,9 @@ <h2 class="title is-4">{% if title %}{{title}}{% else %}{% trans "All plugins" %
 						<img height="32" width="32" class="plugin-icon" src="{% static "images/qgis-icon-32x32.png" %}" alt="{% trans "Plugin icon" %}" />
 					{% endif %}</td>
 					<td>
-						<span class="plugin-name">
+						<a href="{% url "plugin_detail" object.package_name %}" class="plugin-name">
 							{{ object.name }}
-						</span>
+						</a>
 					</td>
 					{% if not user.is_anonymous %}<td>{% if object.approved %}<img src="{% static "images/tick_16.png" %}" />{% else %}&mdash;{% endif %}</td>{% endif %}
 					<td class="has-text-right">{{ object.downloads|intcomma }}</td>

diff --git a/qgis-app/plugins/templates/plugins/plugin_list_grid_card.html b/qgis-app/plugins/templates/plugins/plugin_list_grid_card.html
@@ -16,7 +16,6 @@
             is-flex-direction-column 
             is-justify-content-space-between
         "
-        onclick="window.location.href='{% url "plugin_detail" object.package_name %}';"
         >
 
         {% if object|is_new and not object.featured and not object.deprecated %}
@@ -64,7 +63,11 @@
                     {% endif %}
                 </div>
                 <div class="media-content">
-                    <p class="title is-5">{{ object.name }}</p>
+                    <p class="title is-5">
+                        <a href="{% url "plugin_detail" object.package_name %}">
+                            {{ object.name }}
+                        </a>
+                    </p>
                     {% if object.author %}
                         <p class="subtitle is-7 author">{% trans "by" %} 
                             <a title="{% trans "See all plugins by"%} {{ object.author }}" href="{% url "author_plugins" object.author %}">

diff --git a/qgis-app/static/style/scss/bulma/components/plugins-list.sass b/qgis-app/static/style/scss/bulma/components/plugins-list.sass
@@ -2,7 +2,7 @@
   color: inherit
   tr:hover
     background-color: #ECF1F4
-    cursor: pointer
+    // cursor: pointer
     .rm-past, .rm-future
       color: black
   .button
@@ -23,9 +23,9 @@
     cursor: pointer
 
 .plugins-list-grid
-  .card:hover
-    background-color: #ECF1F4
-    cursor: pointer
+  // .card:hover
+  //   background-color: #ECF1F4
+  //   cursor: pointer
   .card
     +tablet
       height: 100%