Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] [OAPIF provider] Add support for edition capabilities (OGC API Features Part 4) #52504

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Apr 3, 2023

  • Issues OPTIONS on /collections/{coll_id} and collections/{coll_id}/{feature_id} endpoints to check server capabilities
  • Add support for addFeature() through POST /collections/{coll_id} endpoint
  • Add support for changeGeometryValues()/changeAttributeValues() through PUT /collections/{coll_id}/{feature_id} endpoint. Or through PATCH /collections/{coll_id}/{feature_id} with just the updated subset, if available
  • Add support for deleteFeatures() through DELETE /collections/{coll_id}/{feature_id} endpoint.
  • For POST/PUT/PATCH, takes into account Part 2 (CRS support) when implemented by the server.

CC @3nids

@github-actions github-actions bot added this to the 3.32.0 milestone Apr 3, 2023
@rouault rouault force-pushed the ogcapi_part4 branch 3 times, most recently from d207d74 to e3b94c8 Compare April 3, 2023 20:08
@3nids
Copy link
Member

3nids commented Apr 6, 2023

Nice! We've made some testing and it works well. We experienced some quirks but we are quite sure they come from our backend for now.

@nyalldawson
Copy link
Collaborator

@rouault I'm ok if you ignore some of the reviews suggestions -- this may not be performance sensitive enough to warrant the changes!

…es Part 4)

- Issues OPTIONS on /collections/{coll_id} and collections/{coll_id}/{feature_id}
  endpoints to check server capabilities
- Add support for addFeature() through POST /collections/{coll_id} endpoint
- Add support for changeGeometryValues()/changeAttributeValues() through
  PUT /collections/{coll_id}/{feature_id} endpoint.
  Or through PATCH /collections/{coll_id}/{feature_id} with just the
  updated subset, if available
- Add support for deleteFeatures() through
  DELETE /collections/{coll_id}/{feature_id} endpoint.
- For POST/PUT/PATCH, takes into account Part 2 (CRS support) when implemented
  by the server.
@rouault
Copy link
Contributor Author

rouault commented Apr 18, 2023

@nyalldawson do you mind approving this PR?

@nyalldawson nyalldawson merged commit 2924f3e into qgis:master Apr 18, 2023
@DelazJ DelazJ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Jul 11, 2023
@qgis-bot
Copy link
Collaborator

@rouault
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions
Copy link

@rouault
A documentation ticket has been opened at qgis/QGIS-Documentation#8398
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@fredmorin
Copy link

Hello,

I am testing with QGIS 3.34.1 and pg_featureserv CrunchyData/pg_featureserv#152
Features display correctly in QGIS, So the GET method works fine, unfortunatly QGIS does not seem to send OPTIONS calls sent to the backend.

Is there something I am missing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants