Update GxGSV NMEA 4.10 - Add Signal averaging - Update gpsinformationwidget #58357

bettellam · 2024-08-11T09:56:26Z

parse.c
Update GxGSV - NMEA 4.10 signal_id

sentence.h
Add signal_id; //!< NMEA v4.1 - ID of the ranging signal

qgsnmeaconnection.cpp
NMEA RMC - Set qualitydescription only for status: A or V in processRmcSentence
if the value in status is not A or V (e.g. D), for qualitydescription it is set with GGA

NMEA GSV - Add Signal averaging processGsvSentence
QgsSatelliteInfo signal is calculated as the average of the signals present in GxGSV
With future updates using signal_id you may get a result similar to this:

qgsgpsinformationwidget.cpp
Small updates in SkyPlot satellites (added color and different symbol for various constellations)

NMEA RMC - Set qualitydescription only for status: A or V in processRmcSentence NMEA GSV - Add Signal averaging processGsvSentence

github-actions · 2024-08-11T12:25:05Z

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit f14154c)

bettellam · 2024-08-12T09:22:00Z

github-actions · 2024-09-04T02:45:07Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-09-28T02:46:59Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-10-06T02:48:59Z

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

bettellam · 2024-10-13T10:00:32Z

@nyalldawson Ciao
Sorry this request was not merged.

The change to GxGSV is a simple adaptation to NMEA 4.10

The change to GxRMC solves a problem with the new Unicore UM98x receivers, low-cost GNSS receivers that are having a considerable success on par with the UBlox F9P.
In particular with UM98x an improper use of the Status flag is performed in the NMEA GxRMC sentence whose standard values are: A=active or V=void.
UM98x repeats the values of the mode flag.

The current procedure in QGIS only checks Status=A to fix from the Mode flag:
mLastGPSInformation.quality
mLastGPSInformation.qualityIndicator

passing to Void any other value of Status and then:
mLastGPSInformation.quality = Invalid ;
mLastGPSInformation.qualityIndicator = Invalid ;
this makes the UM98x receivers unusable when they switch to RTK Fix mode.

It should be noted that
mLastGPSInformation.quality and
mLastGPSInformation.qualityIndicator
are set using NMEA GxGGA and are therefore correctly present.

A next step for NMEA:
update GxGSA to NMEA 4.10
this will allow to resolve the satellite numbering by introducing the standard character used by the RTCM specifications for the various constellations:
GPS: "G"
GLONASS: "R"
GALILEO: "E"
BEIDOU: "C"
QZSS: "J"
IRNSS/NAVIC: "I"
in addition to the satellite number
(this will avoid double numbering between GPS and GALILEO, currently not resolved in QGis),
it must be said that it will be more readable satellitesInView and satellitesInUse (satprn list) and the Skyplot graphs
Ciao

external/nmea/parse.c

src/app/gps/qgsgpsinformationwidget.cpp

src/core/gps/qgsnmeaconnection.cpp

github-actions · 2024-10-17T06:25:18Z

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit ca902d2)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit ca902d2)

Update for Status not A, V - for UM982 Status = D - Differential when it becomes RTKfix

bettellam · 2024-10-17T12:01:40Z

@nyalldawson test Windows Qt6 builds
Ublox ZED-F9P

UNICORE UM982

NEW Update qgsgpsinformation.cpp

github-actions · 2024-11-26T02:51:17Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-12-03T02:55:18Z

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

bettellam · 2024-12-03T15:07:00Z

Sorry, I don't understand what's wrong!!!
Help...
Thanks!

for more information, see https://pre-commit.ci

github-actions · 2024-12-20T02:47:29Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-12-28T02:46:16Z

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

bettellam · 2025-01-06T08:17:30Z

I found the reason for the reported errors.
https://clang.llvm.org/docs/ClangFormatStyleOptions.html
is it possible to reopen the pull request? thanks

github-actions · 2025-01-21T02:46:04Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2025-01-28T02:46:08Z

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

bettellam · 2025-01-28T15:05:41Z

@nyalldawson hello, should I consider this PR permanently closed or is there a possibility that it will be merged?
thanks . Ciao

bettellam added 4 commits August 11, 2024 11:12

Update GxGSV - NMEA 4.10 signal_id

3f511e2

Add signal_id; //!< NMEA v4.1 - ID of the ranging signal

fa8837f

Update NMEA RMC - GSV

1107331

NMEA RMC - Set qualitydescription only for status: A or V in processRmcSentence NMEA GSV - Add Signal averaging processGsvSentence

Update Skiplot satellites (QWTPOLAR)

9d6a04b

github-actions bot added this to the 3.40.0 milestone Aug 11, 2024

bettellam added 3 commits August 11, 2024 12:11

Update Skiplot satellites (QWTPOLAR) - identation update

e1dd9d7

Update Skiplot satellites (QWTPOLAR) - identation update

9bc8057

Update Skiplot satellites (QWTPOLAR) - identation update

c270fff

bettellam added 3 commits August 20, 2024 19:17

Update Skiplot satellites (QWTPOLAR) - update

8b91ab8

Update Skiplot satellites (QWTPOLAR) - update

c2855a1

Update Skiplot satellites (QWTPOLAR) - update

fb40d15

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 4, 2024

Merge branch 'qgis:master' into patch-1

ded777c

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 4, 2024

Update qgsgpsinformationwidget.cpp change marker size

f14154c

nyalldawson added the Freeze Exempt Feature Freeze exemption granted label Sep 13, 2024

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 28, 2024

github-actions bot closed this Oct 6, 2024

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 13, 2024

nyalldawson reopened this Oct 17, 2024

nyalldawson reviewed Oct 17, 2024

View reviewed changes

external/nmea/parse.c Outdated Show resolved Hide resolved

src/app/gps/qgsgpsinformationwidget.cpp Outdated Show resolved Hide resolved

src/app/gps/qgsgpsinformationwidget.cpp Outdated Show resolved Hide resolved

src/core/gps/qgsnmeaconnection.cpp Outdated Show resolved Hide resolved

Update qgsgpsinformation.cpp

873e78f

Update for Status not A, V - for UM982 Status = D - Differential when it becomes RTKfix

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 26, 2024

github-actions bot closed this Dec 3, 2024

nyalldawson reopened this Dec 3, 2024

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 3, 2024

bettellam added 4 commits December 3, 2024 12:16

Merge branch 'master' into patch-1

37f976e

Update qgsgpsinformationwidget.cpp

353aa92

Update qgsgpsinformationwidget.cpp

2c6bc8e

Update qgsgpsinformationwidget.cpp

8135f85

nyalldawson removed the Freeze Exempt Feature Freeze exemption granted label Dec 4, 2024

bettellam and others added 2 commits December 5, 2024 17:34

Update qgsgpsinformationwidget.cpp

95d128c

[pre-commit.ci] auto fixes from pre-commit.com hooks

ca902d2

for more information, see https://pre-commit.ci

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 20, 2024

github-actions bot closed this Dec 28, 2024

bettellam deleted the patch-1 branch December 29, 2024 09:32

bettellam restored the patch-1 branch January 6, 2025 08:03

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 6, 2025

DelazJ reopened this Jan 6, 2025

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 21, 2025

github-actions bot closed this Jan 28, 2025

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 28, 2025

nyalldawson reopened this Jan 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GxGSV NMEA 4.10 - Add Signal averaging - Update gpsinformationwidget #58357

Update GxGSV NMEA 4.10 - Add Signal averaging - Update gpsinformationwidget #58357

bettellam commented Aug 11, 2024

github-actions bot commented Aug 11, 2024 •

edited

Loading

bettellam commented Aug 12, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 28, 2024

github-actions bot commented Oct 6, 2024

bettellam commented Oct 13, 2024

github-actions bot commented Oct 17, 2024 •

edited

Loading

bettellam commented Oct 17, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Dec 3, 2024

bettellam commented Dec 3, 2024

github-actions bot commented Dec 20, 2024

github-actions bot commented Dec 28, 2024

bettellam commented Jan 6, 2025

github-actions bot commented Jan 21, 2025

github-actions bot commented Jan 28, 2025

bettellam commented Jan 28, 2025

Update GxGSV NMEA 4.10 - Add Signal averaging - Update gpsinformationwidget #58357

Are you sure you want to change the base?

Update GxGSV NMEA 4.10 - Add Signal averaging - Update gpsinformationwidget #58357

Conversation

bettellam commented Aug 11, 2024

github-actions bot commented Aug 11, 2024 • edited Loading

🪟 Windows builds ready!

bettellam commented Aug 12, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 28, 2024

github-actions bot commented Oct 6, 2024

bettellam commented Oct 13, 2024

github-actions bot commented Oct 17, 2024 • edited Loading

🪟 Windows builds

🪟 Windows Qt6 builds

bettellam commented Oct 17, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Dec 3, 2024

bettellam commented Dec 3, 2024

github-actions bot commented Dec 20, 2024

github-actions bot commented Dec 28, 2024

bettellam commented Jan 6, 2025

github-actions bot commented Jan 21, 2025

github-actions bot commented Jan 28, 2025

bettellam commented Jan 28, 2025

github-actions bot commented Aug 11, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading