Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network] Implement a smart cache size #58548

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Aug 31, 2024

Description

This PR improves QGIS' handling of its network disk cache by using a smart cache size logic that dynamically sizes based on the disk cache storage's available space. The logic is taken from Firefox (https://github.com/mozilla/gecko-dev/blob/e0a62f1391f7d58fab20418adc9310b23708a792/netwerk/cache2/CacheFileIOManager.cpp#L4307), and will results in most users getting a larger cache size.

image

The objective here is to insure that our default cache size insures we are as friendly as we can to servers hosting XYZ tiles, incl. but not limited to OpenStreetMap.

Users can disable the smart cache size logic in favor of a static cache size in the Options dialog. On that front, the spin box represents MBs instead of KiBs, because we're in 2024 :)

image

@github-actions github-actions bot added this to the 3.40.0 milestone Aug 31, 2024
@nirvn nirvn force-pushed the smart_disk_cache branch 4 times, most recently from dfcc3dc to 0544092 Compare September 1, 2024 03:03
Copy link

github-actions bot commented Sep 1, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit f0085c6)

@nirvn nirvn force-pushed the smart_disk_cache branch 2 times, most recently from 5ac8bea to 73efe05 Compare September 1, 2024 05:47
src/app/options/qgsoptions.cpp Outdated Show resolved Hide resolved
src/core/network/qgsnetworkdiskcache.cpp Outdated Show resolved Hide resolved
src/core/network/qgsnetworkdiskcache.cpp Outdated Show resolved Hide resolved
src/core/network/qgsnetworkdiskcache.h Outdated Show resolved Hide resolved
src/server/qgsserversettings.cpp Outdated Show resolved Hide resolved
src/ui/qgsoptionsbase.ui Show resolved Hide resolved
src/core/network/qgsnetworkaccessmanager.cpp Outdated Show resolved Hide resolved
src/server/qgsserver.cpp Outdated Show resolved Hide resolved
src/core/qgstiledownloadmanager.cpp Outdated Show resolved Hide resolved
@nirvn
Copy link
Contributor Author

nirvn commented Sep 2, 2024

@rouault , @nyalldawson , @DelazJ , thanks for the reviews, points have been addressed.

Copy link
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nirvn Looks fine regarding my requests.

src/core/network/qgsnetworkdiskcache.cpp Outdated Show resolved Hide resolved
src/core/network/qgsrangerequestcache.cpp Outdated Show resolved Hide resolved
src/app/options/qgsoptions.cpp Outdated Show resolved Hide resolved
src/core/network/qgsnetworkaccessmanager.cpp Outdated Show resolved Hide resolved
@nirvn nirvn merged commit 03af916 into qgis:master Sep 3, 2024
30 checks passed
@DelazJ DelazJ added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 3, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Sep 3, 2024

@nirvn

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Sep 3, 2024

@nirvn
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Sep 3, 2024

@nirvn
A documentation ticket has been opened at qgis/QGIS-Documentation#9228
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants