Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fix project's Ellipsoid option description (adding angle to distance and area) #58660

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

agiudiceandrea
Copy link
Contributor

@agiudiceandrea agiudiceandrea commented Sep 11, 2024

Description

Also angle measurement, besides the distance and area ones, is ellipsoidal. (Unless "None \ Planimetric" ellipsoid is set).

In Project -> Properties -> General -> Measurements:
from

Ellipsoid
(for distance and area calculations)

to

Ellipsoid
(distance, area, angle calculations)

Another possible approach would be to completely remove the (for distance and area calculations) text.
Not sure if this PR is worth to be backported.

EDIT: as suggested in the review, I've removed the text in parenthesis and added a tooltip to the "Ellipsoid" option's label with the text For distance, area and angle calculations.

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 99490b7)

@agiudiceandrea agiudiceandrea added GUI/UX Related to QGIS application GUI or User Experience and removed GUI/UX Related to QGIS application GUI or User Experience labels Sep 11, 2024
@@ -605,7 +605,7 @@
<widget class="QLabel" name="textLabel1_8">
<property name="text">
<string>Ellipsoid
(for distance and area calculations)</string>
(distance, area, angle calculations)</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(distance, area, angle calculations)</string>
(distance, area and angle calculations)</string>

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried not to make the text any longer.
Original:
image
My PR
image
Suggested change:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the text in parenthesis and let's go for a tooltip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?
image
(The tooltip is only on the label, not on the combobox)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated.

@agiudiceandrea agiudiceandrea added GUI/UX Related to QGIS application GUI or User Experience Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Sep 12, 2024
@qgis-bot
Copy link
Collaborator

@agiudiceandrea
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@3nids 3nids merged commit 84e48f9 into qgis:master Sep 12, 2024
26 of 28 checks passed
@qgis-bot
Copy link
Collaborator

@agiudiceandrea
A documentation ticket has been opened at qgis/QGIS-Documentation#9252
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

velle pushed a commit to velle/QGIS that referenced this pull request Sep 17, 2024
…tance and area) (qgis#58660)

* [GUI] Fix project's Ellipsoid option description

* [GUI] Use a tooltip for project's Ellipsoid option description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI/UX Related to QGIS application GUI or User Experience Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants