Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dedicated "show editing toolbar" action from 3d windows #60313

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

nyalldawson
Copy link
Collaborator

Instead add right-click menu to main 3d window toolbar to toggle optional toolbar visibilty, just like we do for the main QGIS window.

This avoids UI bloat in 3d map windows, and removes an action which will be rarely used.

Instead add right-click menu to main 3d window toolbar to toggle
optional toolbar visibilty, just like we do for the main QGIS
window.

This avoids UI bloat in 3d map windows, and removes an action which
will be rarely used.
@nyalldawson nyalldawson added the GUI/UX Related to QGIS application GUI or User Experience label Jan 28, 2025
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 0828224)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 0828224)

@nyalldawson nyalldawson merged commit 0225742 into qgis:master Jan 28, 2025
38 checks passed
@nyalldawson nyalldawson deleted the pc_edit_toolbar branch January 28, 2025 08:04
@uclaros
Copy link
Contributor

uclaros commented Jan 30, 2025

😿
My points against this:

  • I don't think the 3d view toolbar is bloated, it only has 12 buttons, which is 44 less than the main windows' default. If you think that's too many, I'd rather remove the semi-broken on-screen navigation relic button instead.
  • Point cloud editing might be niche, but the toolbar may accommodate other layer types' editing tools in the future. Vector layer 3d editing is a much requested feature.
  • Main window has the editing toolbar visible by default
  • Toolbar position and visibility persist in the main window
    But more importantly:
  • There is no visible clue that the toolbars are dynamic and one needs to right click. In the main window, toolbars have a handle and are movable. Users (or at least many of them) expect it to be right clickable, and even if not, there is a menu entry to manipulate the toolbars. In the secondary views however, both 2d and 3d, this is not the case.
  • Right click does not work on the big blank space to the right of the last item of the main toolbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants