[Masking] Fix copy/paste of symbol or converting renderer #60325
Conversation
Both symbol layer ids and masks need to be removed from symbol layers which can be inherited from a converted renderer
troopa81
changed the title
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
| { | ||
| if ( QgsSymbolLayer *sl = symbol->symbolLayer( idx ) ) | ||
| { | ||
| sl->clearMasks(); |
There was a problem hiding this comment.
I'd lean toward a dynamic_cast to QgsMaskMarkerSymbolLayer here and then directly calling QgsMaskMarkerSymbolLayer::clearMasks to avoid the virtual clearMasks method in QgsSymbolLayer.
If later on we find other symbol layer types which need this handled then we can safely resurrect the virtual method without any API breakage.
There was a problem hiding this comment.
I considered this solution but preferred to have clearMasks() method for 2 reasons:
- to be consistent with masks() method (this is not the case of setMasks() but maybe this one should also be defined as a virtual method of QgsSymbolLayer)
- dynamic_cast is a bad design and should be avoided
Even if we never get a symbol layer types implementing masks, why do you think it is better with dynamic_cast ?
Properly reset symbol layer ids when copy/pasting symbol or when converting a rule based renderer into a categorized renderer.
Fixes #46402 where issues comes from symbol layers having identical symbol layers ids, coming from I presume, actions described just above