-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to delegate bounding box transformation to proj on >= 8.2 #60331
base: master
Are you sure you want to change the base?
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
78e92e0
to
db408ad
Compare
Tests failed for Qt 5One or more tests failed using the build from commit 8edbe0d 4978_2D_line_rendering (epsg4978LineRendering)4978_2D_line_renderingTest failed at epsg4978LineRendering at tests/src/core/testqgsclipper.cpp:207 Rendered image did not match tests/testdata/control_images/3d/expected_4978_2D_line_rendering/expected_4978_2D_line_rendering.png (found 63794 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 6One or more tests failed using the build from commit 8edbe0d 4978_2D_line_rendering (epsg4978LineRendering)4978_2D_line_renderingTest failed at epsg4978LineRendering at tests/src/core/testqgsclipper.cpp:207 Rendered image did not match tests/testdata/control_images/3d/expected_4978_2D_line_rendering/expected_4978_2D_line_rendering.png (found 63794 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
on released versions of PROJ, yes, since I fixed 3D support only in PROJ master per OSGeo/PROJ#4333 a couple months ago |
I'd just add a PROJ_VERSION < 9.6 protection around your commit |
Opening for CI run