Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to delegate bounding box transformation to proj on >= 8.2 #60331

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nyalldawson
Copy link
Collaborator

Opening for CI run

@nyalldawson nyalldawson added the NOT FOR MERGE Don't merge! label Jan 29, 2025
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 8edbe0d)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 8edbe0d)

@qgis qgis deleted a comment from github-actions bot Jan 30, 2025
@qgis qgis deleted a comment from github-actions bot Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Tests failed for Qt 5

One or more tests failed using the build from commit 8edbe0d

4978_2D_line_rendering (epsg4978LineRendering)

4978_2D_line_rendering

Test failed at epsg4978LineRendering at tests/src/core/testqgsclipper.cpp:207

Rendered image did not match tests/testdata/control_images/3d/expected_4978_2D_line_rendering/expected_4978_2D_line_rendering.png (found 63794 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

Copy link

github-actions bot commented Jan 30, 2025

Tests failed for Qt 6

One or more tests failed using the build from commit 8edbe0d

4978_2D_line_rendering (epsg4978LineRendering)

4978_2D_line_rendering

Test failed at epsg4978LineRendering at tests/src/core/testqgsclipper.cpp:207

Rendered image did not match tests/testdata/control_images/3d/expected_4978_2D_line_rendering/expected_4978_2D_line_rendering.png (found 63794 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@nyalldawson
Copy link
Collaborator Author

@rouault is 8edbe0d a known requirement for proj_trans_bounds?

@rouault
Copy link
Contributor

rouault commented Jan 30, 2025

is 8edbe0d a known requirement for proj_trans_bounds?

on released versions of PROJ, yes, since I fixed 3D support only in PROJ master per OSGeo/PROJ#4333 a couple months ago

@nyalldawson
Copy link
Collaborator Author

Thanks @rouault !

I noticed that fix is similar to my workaround in 8edbe0d. Do you think we should:

  1. Defer this whole change till newer proj is available.
  2. Use the (buggy) old qgis logic when a compound crs is in play
  3. Or conditionally apply the same logic as the proj fix?

@rouault
Copy link
Contributor

rouault commented Jan 30, 2025

Do you think we should:

I'd just add a PROJ_VERSION < 9.6 protection around your commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT FOR MERGE Don't merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants