Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single shot refactoring #1086

Draft
wants to merge 11 commits into
base: 0.1
Choose a base branch
from
Draft

Single shot refactoring #1086

wants to merge 11 commits into from

Conversation

Edoardo-Pedicillo
Copy link
Contributor

This PR removes all the shenanigans regarding the use of different classification methods in the single shot routine and uses the same acquisition and post-processing in both single shot and resonator_amplitude protocols.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (d8e8dda) to head (76b6b6f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   97.33%   97.01%   -0.33%     
==========================================
  Files         123      123              
  Lines        9844     9740     -104     
==========================================
- Hits         9582     9449     -133     
- Misses        262      291      +29     
Flag Coverage Δ
unittests 97.01% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/auto/operation.py 97.95% <100.00%> (+0.01%) ⬆️
src/qibocal/fitting/classifier/qubit_fit.py 98.43% <100.00%> (-1.57%) ⬇️
src/qibocal/fitting/classifier/run.py 62.18% <ø> (-35.30%) ⬇️
src/qibocal/protocols/classification.py 100.00% <100.00%> (+5.94%) ⬆️
src/qibocal/protocols/qutrit_classification.py 100.00% <100.00%> (ø)
...tocols/readout_optimization/resonator_amplitude.py 100.00% <100.00%> (ø)
...tocols/readout_optimization/resonator_frequency.py 99.00% <100.00%> (ø)
src/qibocal/protocols/utils.py 94.18% <100.00%> (+1.15%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Qblox classifier classification.py dumps data to unwanted location
1 participant