Fix drag pulse helper method #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 66.35% 66.51% +0.16%
==========================================
Files 50 50
Lines 6063 6063
==========================================
+ Hits 4023 4033 +10
+ Misses 2040 2030 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alecandido
approved these changes
Mar 20, 2024
src/qibolab/platform.py
Outdated
| qubit = self.get_qubit(qubit) | ||
| pulse = self.qubits[qubit].native_gates.RX90.pulse(start, relative_phase) | ||
| if beta is not None: | ||
| pulse.shape = "Drag(5," + str(beta) + ")" | ||
| pulse.shape = Drag(rel_sigma=pulse.shape.rel_sigma, beta=beta) | ||
| return pulse | ||
|
|
||
| def create_RX_drag_pulse(self, qubit, start, relative_phase=0, beta=None): |
There was a problem hiding this comment.
Is this method truly useful with beta=None?
There was a problem hiding this comment.
We can drop the default and make beta a required argument, which should make sense given that if the user asks for a drag pulse should provide also beta.
stavros11
reviewed
Mar 20, 2024
stavros11
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing qiboteam/qibocal#689 I noticed that the platform's helper methods for creating drag pulses were broken (I was the one who implemented them...). This PR fixes the issue.
Checklist: