Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added column_name variability to resource_allocation #3457

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

Added column_name variability to resource_allocation #3457

wants to merge 25 commits into from

Conversation

Gossty
Copy link
Contributor

@Gossty Gossty commented Feb 11, 2025

No description provided.

Gossty and others added 21 commits April 29, 2024 17:28
@Gossty
Update to DB qiita.slurm_resource_allocations
88dc031
@Gossty
Merge branch 'dev' of https://github.com/qiita-spots/qiita into dev
447e01a
@Gossty
Merge branch 'dev' of https://github.com/qiita-spots/qiita into dev
442e735
@Gossty
Merge branch 'dev' of https://github.com/qiita-spots/qiita into dev
43aa8bf
@Gossty
Merge branch 'dev' of https://github.com/qiita-spots/qiita into dev
3afba3a
@Gossty
Merge branch 'dev' of https://github.com/qiita-spots/qiita into dev
a36dc8a
@Gossty
Merge branch 'dev' of https://github.com/qiita-spots/qiita into dev
071eb5f
@Gossty
Merge branch 'dev' of https://github.com/qiita-spots/qiita into dev
2ecfa1e
@Gossty
added colormap, create equation table
d5996f1
@Gossty
Fixed styling
dd12143
@Gossty
Using qiita.allocation_equations table in util.py
1c30fc8
@Gossty
Debug
82c95e1
@Gossty
Updates to @antgonza comments
2cb3f37
@Gossty
Changes to @antgonza comments
2ea03e2
@Gossty
Back to np.log
60ec9fd
@Gossty
Added column_name variability
49b4a79
@Gossty
Fix styling
fbe01a2
@Gossty
Merge branch 'dev' into resource-allocation-colormap
7da3659
@Gossty
Update description of software retrieval function
9717adb
@Gossty
Remove the unnecessary test_db 94.sql file
8d27f89
@Gossty
Update test_user.py
7fb202a
antgonza
antgonza requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Gossty; a few comments, I'll do another pass once these are fixed.

antgonza
antgonza requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Gossty, thank you for the updates. Some minor comments/questions.

@coveralls
Copy link

coveralls commented Feb 13, 2025 •
edited
Loading

Coverage Status

coverage: 92.354% (-0.04%) from 92.392%
when pulling 8e148b6 on Gossty:resource-allocation-colormap
into 08ce025 on qiita-spots:dev.

@Gossty
Time limit for resource_allocation_plot
8e148b6 
1. Created time limit for resource_allocation_plot using signal library.
2. Don’t show failures in legend if no failures.
3. Added more robust print statements with timestamps.
4. Only populate commands to qiita_pet when plots were created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgonza antgonza antgonza requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gossty @coveralls @antgonza