Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qiskit-neko integration tests #162

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

ElePT
Copy link
Collaborator

@ElePT ElePT commented Feb 23, 2024

Summary

Since Qiskit/qiskit-neko#34, the qiskit-neko nature and primitives tests use qiskit_algorithms.

This PR adds a new CI job to run the neko integration tests to (double) check that a proposed PR does not regress compatibility on an API or an integration point with another qiskit project and ensure that algorithms doesn't break CI for another project using neko.

Details and comments

Gap discovered in Qiskit/qiskit-neko#41.

I've added two jobs, one for the nature tests and one for the primitives tests because I didn't find a way to squeeze both options into one job. Feel free to suggest how to do it if you have a better alternative. --> The better alternative is using the new component added in Qiskit/qiskit-neko#43.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8019925179

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.653%

Totals Coverage Status
Change from base Build 8008181587: 0.0%
Covered Lines: 6488
Relevant Lines: 7157

💛 - Coveralls

@ElePT ElePT removed the on hold Can not fix yet label Feb 26, 2024
@ElePT ElePT merged commit b8315a2 into qiskit-community:main Feb 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants