Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a deadline on clients #69

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michaeldelago
Copy link
Contributor

@michaeldelago michaeldelago commented Jun 23, 2024

This PR sets up a basic implementation for deadlines from grpc clients. This is roughly described in #68

Request for comments - what do we think of this implementation? is there a better way we can do it? My goal is to keep the syntax for setting the deadline relatively ergonomic in the code. Ideally we'd be able to add the other parameters to fill out the C signature for grpc_channel_create_call (used here).

Open TODO's:

  • tests
    • asserting that the server can receive the deadline and confirm it's properly set
    • asserting that the server fails on a deadline and signals the appropriate condition

@@ -21,6 +21,9 @@
(defvar *completion-queue* nil "The global completion queue used to
manage grpc calls.")

(defvar *call-deadline* nil
"The deadline for a grpc call. The default, nil, specifies an infinite deadline")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is something that should be a defvar, more something you specify, and the user can make a defvar and set in their code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants