Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML style options #113

Merged
merged 20 commits into from
Oct 29, 2024
Merged

YAML style options #113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8128fb9
Proof of concept YAMNL config option
jimjam-slam Oct 25, 2024
9cb86ba
Add more properties (not all are hooked up)
Oct 25, 2024
05d3d3a
Merge branch 'dev' into jimjam-slam/issue99
Oct 26, 2024
2f73a20
Move home page customisation to YAML options
Oct 26, 2024
a49dd1f
Hook up additional properties
Oct 26, 2024
0c8c4f3
Continue home page customisation w YAML options
Oct 26, 2024
500c38d
Fix poem styles
Oct 26, 2024
e584f75
Simplify NYTimes styles
Oct 26, 2024
d3e0b76
Tweak Minard-Tufte
Oct 26, 2024
ddd76ef
Add YAML styles to demo docs
Oct 26, 2024
820312a
Fix comma-separated style options
Oct 27, 2024
16abfda
finetune sidebar
andrewpbray Oct 28, 2024
1c246c9
add sidebar-width
andrewpbray Oct 28, 2024
a518e54
change cr-sidebar-width to use apply to grid-tempmlate-columns.
andrewpbray Oct 28, 2024
ed18ff7
Move style options to `cr-style` key
Oct 29, 2024
4a8e2a3
Change trigger var names to narrative
Oct 29, 2024
00111e4
Adjust NYTimes sidebar sizing
Oct 29, 2024
dcede17
Tweak narrative overlay vare names, and hook up min width
Oct 29, 2024
a3ddd84
Remove BS color var deps; rename sidebar BG var
Oct 29, 2024
f12f30c
Adjust overlay BG color default
Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _extensions/closeread/closeread.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion _extensions/closeread/closeread.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion _extensions/closeread/closeread.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ local allowed_style_options = {
"trigger-font-size",
"poem-font-family",
"sidebar-background-color",
"section-background-color"
"section-background-color",
"sidebar-width",
}

--======================--
Expand Down
2 changes: 2 additions & 0 deletions _extensions/closeread/closeread.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
grid-column: 1;
margin-inline: 0;
background-color: var(--cr-sidebar-background-color);
width: var(--cr-sidebar-width);
jimjam-slam marked this conversation as resolved.
Show resolved Hide resolved

.narrative {
padding: 0 0.75em;
Expand Down Expand Up @@ -316,6 +317,7 @@ body.cr-removeheaderspace {
--cr-trigger-text-color-sidebar: var(--bs-dark);
--cr-trigger-border-radius: 1em;
--cr-trigger-max-width: 527.98px;
--cr-trigger-min-width: none;
--cr-trigger-outer-margin: 5%;
--cr-trigger-font-family: var(--bs-body-font-family);
--cr-trigger-font-size: 1.15rem;
Expand Down
Loading