Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom To #76

Merged
merged 18 commits into from
Aug 14, 2024
Merged

Zoom To #76

merged 18 commits into from
Aug 14, 2024

Conversation

andrewpbray
Copy link
Contributor

@andrewpbray andrewpbray commented Aug 13, 2024

  • Refactor poem scaling code into a separate zoomTo function that runs inside transformSticky
  • Test that it works for: line block line number
  • Test that it works for: line block span
  • Test that it works for: code cell line number
  • Add hlz option to do both highlighting and zooming.
  • Add .scale-to-fill class to apply a transform on an sticky whenever its active

Merge branch 'main' into feature-zoom-to
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@andrewpbray
Copy link
Contributor Author

andrewpbray commented Aug 14, 2024

@jimjam-slam I believe we have a refactored zooming system that does zooming via zoom-to 🪩 . This allows uses to separately use either highlight or zoom-to on code or lineblocks. If they want to invoke both, they can use the hlz attribute that, on document load, just writes out the analogous highlight and zoom-to attributes for that trigger.

I'll try to get some docs up and possibly if I have energy before tomorrow, expanding the functionality to display math blocks.

@andrewpbray andrewpbray merged commit d1c068d into main Aug 14, 2024
@andrewpbray andrewpbray deleted the feature-zoom-to branch August 14, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant