Reset source detection #6702
Closed
Reset source detection #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanfali
approved these changes
Sep 8, 2019
drashna
approved these changes
Sep 21, 2019
|
As discussed in qmk/lufa#5 I think this new define may not actually be necessary. I would also like to hear back from Dean in abcminiuser/lufa#150 about how the detection is supposed to work first. |
|
Thank you for your contribution! |
|
merge conflicts |
|
This issue has been automatically closed because it has not had any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to allow the keyboard to use a bootloader that checks if the reset source was by pulling the reset pin low, or if it wasn't. This allows the use of PE2 as a normal GPIO pin, as it doesn't have to be pulled low to enter bootloader.
Currently HWBE fuse bit is required. The HWBE fuse bit makes the ATMega32U4 enter the bootloader section if a reset occurs, and PE2 is low. Instead, with this change, one can use PE2 and then set the BOOTRST fuse bit, which makes the ATMega32U4 always boot into the bootloader, and then allowing the bootloader to check the source of the reset, and decide if it should jump straight to the main application, or if it should run the bootloader.
This shouldn't be merged before qmk/lufa#5, as it relies on that.
Types of Changes
Checklist