refactor: use ember-lifeline to avoid eslint error

qonto · Sep 18, 2024 · 7eab17c · 7eab17c
1 parent afb19d4
commit 7eab17c
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 19 deletions.
diff --git a/ember-autofocus-modifier/package.json b/ember-autofocus-modifier/package.json
@@ -35,6 +35,7 @@
   },
   "dependencies": {
     "@embroider/addon-shim": "^1.8.7",
+    "ember-lifeline": "^7.0.0",
     "ember-modifier": "^4.1.0"
   },
   "devDependencies": {

diff --git a/ember-autofocus-modifier/src/modifiers/autofocus.ts b/ember-autofocus-modifier/src/modifiers/autofocus.ts
@@ -1,5 +1,5 @@
 import { modifier } from "ember-modifier";
-import { next } from "@ember/runloop";
+import { runTask } from "ember-lifeline";
 
 const focusableElements = [
   "BUTTON",
@@ -68,7 +68,7 @@ const autofocus = modifier<ModifierArgs>(function autofocus(
     element.setAttribute("tabindex", "-1");
   }
 
-  next(function () {
+  runTask(element, function () {
     targetElement.focus();
   });
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test-app/config/ember-try.js b/test-app/config/ember-try.js
@@ -101,18 +101,18 @@ module.exports = async function () {
       embroiderSafe({
         npm: {
           devDependencies: {
-            '@embroider/compat': '^3.2.1',
-            '@embroider/core': '^3.2.1',
-            '@embroider/webpack': '^3.1.5',
+            '@embroider/compat': '^3.3.0',
+            '@embroider/core': '^3.4.0',
+            '@embroider/webpack': '^3.2.1',
           },
         },
       }),
       embroiderOptimized({
         npm: {
           devDependencies: {
-            '@embroider/compat': '^3.2.1',
-            '@embroider/core': '^3.2.1',
-            '@embroider/webpack': '^3.1.5',
+            '@embroider/compat': '^3.3.0',
+            '@embroider/core': '^3.4.0',
+            '@embroider/webpack': '^3.2.1',
           },
         },
       }),