-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TypeScript configuration #432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycalleri
force-pushed
the
typescript-setup
branch
from
September 26, 2023 08:30
f8e9d60
to
4458c15
Compare
dannycalleri
force-pushed
the
typescript-setup
branch
3 times, most recently
from
September 27, 2023 13:30
5fdf2ef
to
d534d36
Compare
dannycalleri
force-pushed
the
typescript-setup
branch
2 times, most recently
from
September 28, 2023 14:30
e549bc9
to
7e9e827
Compare
dannycalleri
force-pushed
the
typescript-setup
branch
from
September 28, 2023 15:03
7e9e827
to
f50d744
Compare
vscav
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me 🔥 Nice job, thanks!
I did some "QA" - I just checked out your branch to ensure the type declaration files are well outputted during the addon build. And this is the case!
vscav
changed the title
Add TypeScript configuration
feat: add TypeScript configuration
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to TypeScript for both
ember-autofocus-modifier
and thetest-app
.Related to qonto/ember-amount-input#543