fix(peer-deps): explicitly set ember-source versions range #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycalleri
force-pushed
the
ember-peer-dependencies
branch
4 times, most recently
from
523bbca
to
7b0d66e
Compare
dannycalleri
force-pushed
the
ember-peer-dependencies
branch
from
7b0d66e
to
462d2a8
Compare
poulet42
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our test suite runs test for specific ember versions (that are also specified in our README) we're setting them explicitly in the
peerDependenciesfor the package.Related to qonto/ember-amount-input#587.