Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure commitlint on CI #506

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

dannycalleri
Copy link
Collaborator

With this PR we want to build upon #309 and set up commitlint to run on CI when pushing to main or doing any kind of activity on a pull request.

This workflow will:

  • Check out the repository with all its history
  • Set up Node and pnpm
  • Install commitlint (with cache support)
  • Validate last commit and PR commits

@michelegera
Copy link
Contributor

Hi @dannycalleri 👋

I recently made some formatting changes to this workflow on ember-lottie (via qonto/ember-lottie#323) to ensure that we have name as the first item of each step, and that steps are visually separated by blank lines.

Not blocking, but would be great if you could adapt this PR as well! WDYT?

@dannycalleri dannycalleri marked this pull request as ready for review December 12, 2023 14:27
@dannycalleri
Copy link
Collaborator Author

I recently made some formatting changes to this workflow on ember-lottie (via qonto/ember-lottie#323) to ensure that we have name as the first item of each step, and that steps are visually separated by blank lines.

Not blocking, but would be great if you could adapt this PR as well! WDYT?

Done, thanks for that 🙏

@dannycalleri dannycalleri merged commit f1ba7b8 into master Dec 12, 2023
16 checks passed
@dannycalleri dannycalleri deleted the configure-commitlint-ci branch December 12, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants