Add nullability annotations to LoggingEvent #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So make it clearer to client code that some of the collections can be null Signed-off-by: Magnus Reftel <[email protected]>
reftel
force-pushed
the
feature/markerlist_nullable
branch
from
4e5a777 to
06b1ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So make it clearer to client code that some of the collections can be null. Only implements it for the class that tripped us up, and only for the methods where it seemed clear if null was possible/supported. Uses jspecify instead of jsr-305 as suggested in SLF4J-418, as everyone seems to be converging on that.