Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds containerd socket hostpath mount #145

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

jonfriesen
Copy link
Contributor

@jonfriesen jonfriesen commented Feb 7, 2025

default

helm template ./charts/qpoint-tap

          volumeMounts:
            # ...
            - mountPath: /sys
              name: sys
              readOnly: true
+           - name: containerd-socket
+             mountPath: /run/containerd/containerd.sock
      volumes:
        # ...
        - hostPath:
            path: /sys
            type: Directory
          name: sys
+       - name: containerd-socket
+         hostPath:
+           path: /run/containerd/containerd.sock
+           type: Socket

containerd disabled

helm template ./charts/qpoint-tap --set integrations.containerd.enabled=false

          volumeMounts:
            # ...
            - mountPath: /sys
              name: sys
              readOnly: true
      volumes:
        # ...
        - hostPath:
            path: /sys
            type: Directory
          name: sys

containerd override host socket path

helm template ./charts/qpoint-tap --set integrations.containerd.hostSocketPath=/some/other/path

          volumeMounts:
            # ...
            - mountPath: /sys
              name: sys
              readOnly: true
+           - name: containerd-socket
+             mountPath: /run/containerd/containerd.sock
      volumes:
        # ...
        - hostPath:
            path: /sys
            type: Directory
          name: sys
+       - name: containerd-socket
+         hostPath:
+           path: /some/other/path
+           type: Socket

@jonfriesen jonfriesen marked this pull request as draft February 7, 2025 21:01
@kamaln7 kamaln7 marked this pull request as ready for review February 11, 2025 13:01
@kamaln7 kamaln7 requested a review from tylerflint February 11, 2025 13:02
@jonfriesen jonfriesen merged commit bc3d61d into main Feb 11, 2025
1 check passed
@jonfriesen jonfriesen deleted the jon/eng-129-update-helm-chart-mounts branch February 11, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants