Jointjs update merge #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few fixes for requirejs config to make JointJS load properly. Also jQuery updated to 2.2.4.
|
Why joint.css is old version? |
TanVD
suggested changes
Mar 12, 2017
| <script src="<c:url value='/resources/js/libs/context-menu/context-menu.js' />"></script> | ||
| <script src="<c:url value='/resources/js/libs/bootstrap/bootstrap.min.js' />"></script> | ||
| <%--<script src="<c:url value='/resources/js/libs/bootstrap/bootstrap.min.js' />"></script>--%> | ||
| <script src="<c:url value='/resources/js/libs/raphael/raphael-min.js' />"></script> |
There was a problem hiding this comment.
better move all those libs to Require.js (if possible, if not -- use hack used for joint)
| ['jointjs'] | ||
| , function (joint) { | ||
| console.log('Adding joint to global'); | ||
| this.joint = joint; |
|
Also images not rendered in Firefox |
|
JointJS.css updated but in Firefox drag and drop from palette still not working. |
saimonsaret
reviewed
Mar 21, 2017
|
|
||
| jquery: '../libs/jquery/jquery', | ||
| jqueryui: '../libs/jquery/ui/jquery-ui', | ||
| jquerytree: '../libs/jquery/treeview/jquery.treeview', |
There was a problem hiding this comment.
Seems like jquery.line is missing. It is impossible to link nodes and draw gestures using right click now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.