[4804][IMP] sale_order_pricelist_commitment_date #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… secondary_uom_price calculation
yostashiro
reviewed
Dec 16, 2024
There was a problem hiding this comment.
IMO, it would be better to just update sale_order_pricelist_commitment_date instead of having changes on the same method in two separate modules.
- Add
sale_order_secondary_unit_priceas a dependency ofsale_order_pricelist_commitment_date - Adjust
onchange_commitment_date()accordingly - No changes on
sale_order_secondary_unit_price
AungKoKoLin1997
force-pushed
the
12.0-imp-sale_order_pricelist_commitment_date
branch
from
0452024 to
83a0dce
Compare
yostashiro
reviewed
Feb 17, 2025
Comment on lines
13
to
16
| "depends": [ | ||
| "sale", | ||
| "product_secondary_unit", | ||
| ], |
There was a problem hiding this comment.
Avoid making unnecessary changes.
Comment on lines
18
to
21
| date=self.date_order, | ||
| pricelist=self.pricelist_id.id, | ||
| uom=line.product_uom.id, | ||
| commitment_date=self.commitment_date, |
There was a problem hiding this comment.
Suggested change
| date=self.date_order, | |
| pricelist=self.pricelist_id.id, | |
| uom=line.product_uom.id, | |
| commitment_date=self.commitment_date, | |
| date=self.commitment_date, | |
| pricelist=self.pricelist_id.id, | |
| uom=line.product_uom.id, | |
| fiscal_position=self.env.context.get("fiscal_position"), |
How about making it like this, and removing the adjustment on _compute_price_rule()?
yostashiro
requested changes
Feb 17, 2025
Comment on lines
18
to
21
| date=self.commitment_date, | ||
| pricelist=self.pricelist_id.id, | ||
| uom=line.product_uom.id, | ||
| fiscal_position=self.env.context.get("fiscal_position"), |
There was a problem hiding this comment.
Suggested change
| date=self.commitment_date, | |
| pricelist=self.pricelist_id.id, | |
| uom=line.product_uom.id, | |
| fiscal_position=self.env.context.get("fiscal_position"), | |
| date=self.date_order, | |
| pricelist=self.pricelist_id.id, | |
| uom=line.product_uom.id, | |
| fiscal_position=self.env.context.get("fiscal_position"), | |
| commitment_date=self.commitment_date, |
Comment on lines
1
to
20
| # Copyright 2020 Quartile Limited | ||
| # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). | ||
|
|
||
| from odoo import api, fields, models | ||
|
|
||
|
|
||
| class Pricelist(models.Model): | ||
| _inherit = "product.pricelist" | ||
|
|
||
| @api.multi | ||
| def _compute_price_rule(self, products_qty_partner, date=False, uom_id=False): | ||
| date = ( | ||
| self._context.get("commitment_date") | ||
| or self._context.get("date") | ||
| or fields.Date.today() | ||
| ) | ||
| date = fields.Date.to_date(date) | ||
| return super(Pricelist, self)._compute_price_rule( | ||
| products_qty_partner=products_qty_partner, date=date, uom_id=uom_id | ||
| ) |
|
@kanda999 @nobuQuartile Please review when you are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4804