feat: add support for JSON null value #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
==========================================
- Coverage 94.55% 93.82% -0.73%
==========================================
Files 5 5
Lines 1267 1653 +386
==========================================
+ Hits 1198 1551 +353
- Misses 37 70 +33
Partials 32 32 ☔ View full report in Codecov by Sentry. |
mdawar
commented
Oct 19, 2024
| // UnmarshalJSON implements the [json.Unmarshaler] interface. | ||
| func (d *Decimal) UnmarshalJSON(data []byte) error { | ||
| // Remove quotes if they exist. | ||
| if len(data) >= 2 && data[0] == '"' && data[len(data)-1] == '"' { | ||
| data = data[1 : len(data)-1] | ||
| } | ||
|
|
||
| // null value. | ||
| if bytes.Equal(data, nullValue) { |
There was a problem hiding this comment.
The bytes.Equal function is optimized for performance and will perform much better than bytes.Compare.
There was a problem hiding this comment.
I'm good with this. Just add benchmark here for reference
goos: linux
goarch: amd64
cpu: Intel(R) Core(TM) i9-14900HX
BenchmarkByteEqual-32 1000000000 0.1213 ns/op 0 B/op 0 allocs/op
BenchmarkByteCmp-32 247671904 4.825 ns/op 0 B/op 0 allocs/op
quagmt
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This pull request is a suggestion to add support for the JSON
nullvalue.This is needed to prevent parse errors when an API returns a
nullvalue for audecimal.Decimaltype.Other libraries like https://github.com/shopspring/decimal already support this.