Depracation warning for parameter names not being valid python identifiers #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentifier First step for solving #274. This covers all outcome and parameter classes. Still remaining are constants and potentially all Point subclasses.
from NamedObject to Variable, which means Constant name now also must be a valid python identifier
for more information, see https://pre-commit.ci
…kbench into valid_identifiers
for more information, see https://pre-commit.ci
EwoutH
reviewed
Dec 15, 2023
|
Globally, looks good! Ideally, clean up the commits into:
Otherwise squashing on merge would also be fine. I would just make sure it doesn't cause major conflicts with #274. |
Co-authored-by: Ewout ter Hoeven <[email protected]>
|
How would I manage reorganizing the commits because I agree that a clean history would be a convenient. |
|
In my process I use GitHub desktop. You can drag and drop commits to reorder them. Then you squash the ones that work on the same feature (for example squashing all the testing commits to one commit). See Reordering commits in GitHub Desktop. If you're more of a CLI person: 7.6 Git Tools - Rewriting History. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #274 for details. This just turns the exception into a deprecation warning in preparation for the 2.5 release