Merge pull request #43872 from phillip-kruger/dev-ui-custom-side-menu…

…-fix Dev UI: Small cosmetic fix for dynamic menus
quarkusio · Oct 15, 2024 · 143bd48 · 143bd48
2 parents 7773228 + acf4f18
commit 143bd48
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-menu.js b/extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-menu.js
@@ -218,7 +218,7 @@ export class QwcMenu extends observeState(LitElement) {
 
                 let items = [{ text: 'Remove', action: 'remove', id: page.id , namespace: page.namespace}];
                 return html`<vaadin-context-menu .items=${items} @item-selected=${this._handleContextMenu} title="${extensionName}">
-                            ${this._renderItem(page, index)}
+                            ${this._renderItem(page, -1)}
                         </vaadin-context-menu>`;
             }
         }
@@ -295,7 +295,11 @@ export class QwcMenu extends observeState(LitElement) {
                 hasMenuItem = true;
             }
         }
-
+        if(!hasMenuItem){
+            // Check the dynamic pages
+            hasMenuItem = this._dynamicMenuNamespaces.some(item => item.namespace === this._selectedPage);
+        }
+
         if(!hasMenuItem && index === 0){
             return "item selected";
         }