-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Micrometer and OpenTelemetry to the WebSockets Next extension #41956
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Crickey, I just mentioned that #39143 (comment) wants messages per connection and destination. Missed it till now. I'll make this draft and try to address it ASAP. |
7f0d79f
to
f10d66e
Compare
f10d66e
to
9cb15b3
Compare
I think this is ready for review. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9cb15b3
to
f5effce
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7c325ce
to
22b00b4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...ext/runtime/src/main/java/io/quarkus/websockets/next/runtime/telemetry/ErrorInterceptor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Checking out the PR and Reviewing now... Will take some time. It's a biggie :) |
dbbe900
to
226fc67
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
to address agreed changes for |
226fc67
to
0fee520
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a01b3d2
to
fc21e37
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@mkouba we are close to the cut-off for features that will be in 3.14 and 3.15 LTS. So if you want this in, we will have to merge it very very soon as in before next Tuesday :). |
@gsmet I'm pretty sure we won't make it :-( This is a massive PR that needs a detailed review. I will meet with Michal by the end of August. |
Please include me. |
fc21e37
to
53805a4
Compare
Rebased on current main as this was pretty old now. |
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview ffd0c78 has been successfully built and deployed to https://quarkus-pr-main-41956-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
I'll just rebase this on current main, no changes. |
53805a4
to
df501f1
Compare
Status for workflow
|
Status for workflow
|
closes: #39143